diff options
| author | Jeff Darcy <jdarcy@fb.com> | 2017-06-29 06:50:56 -0700 |
|---|---|---|
| committer | Niels de Vos <ndevos@redhat.com> | 2017-06-30 10:31:02 +0000 |
| commit | 0be8e038d9bf90be94f3e3a7d6ea5bee88da9ecb (patch) | |
| tree | 2f23f3b205a9bdd386488cc00a3d4b1f23b4a076 /libglusterfs/src/refcount.h | |
| parent | 50d72373fadf1174918e754e31bae3806aa4c214 (diff) | |
multiple: fix struct/typedef inconsistencies
The most common pattern, both in our code and elsewhere, is this:
struct _xyz {
...
};
typedef struct _xyz xyz_t;
These exceptions - especially call_frame/call_stack - have been slowing
down code navigation for years. By converging on a single pattern,
navigating from xyz_t in code to the actual definition of struct _xyz
(i.e. without having to visit the typedef first) might even be
automatable.
Change-Id: I0e5dd1f51f98e000173c62ef4ddc5b21d9ec44ed
Signed-off-by: Jeff Darcy <jdarcy@fb.com>
Reviewed-on: https://review.gluster.org/17650
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Jeff Darcy <jeff@pl.atyp.us>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Diffstat (limited to 'libglusterfs/src/refcount.h')
| -rw-r--r-- | libglusterfs/src/refcount.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/libglusterfs/src/refcount.h b/libglusterfs/src/refcount.h index 4ae37fecbfe..25f44258e42 100644 --- a/libglusterfs/src/refcount.h +++ b/libglusterfs/src/refcount.h @@ -26,7 +26,7 @@ typedef void (*gf_ref_release_t)(void *data); -struct _gf_ref_t { +struct _gf_ref { #ifdef REFCOUNT_NEEDS_LOCK gf_lock_t lk; /* lock for atomically adjust cnt */ #endif @@ -35,7 +35,7 @@ struct _gf_ref_t { gf_ref_release_t release; /* cleanup when cnt == 0 */ void *data; /* parameter passed to release() */ }; -typedef struct _gf_ref_t gf_ref_t; +typedef struct _gf_ref gf_ref_t; /* _gf_ref_get -- increase the refcount |