From 0be8e038d9bf90be94f3e3a7d6ea5bee88da9ecb Mon Sep 17 00:00:00 2001 From: Jeff Darcy Date: Thu, 29 Jun 2017 06:50:56 -0700 Subject: multiple: fix struct/typedef inconsistencies The most common pattern, both in our code and elsewhere, is this: struct _xyz { ... }; typedef struct _xyz xyz_t; These exceptions - especially call_frame/call_stack - have been slowing down code navigation for years. By converging on a single pattern, navigating from xyz_t in code to the actual definition of struct _xyz (i.e. without having to visit the typedef first) might even be automatable. Change-Id: I0e5dd1f51f98e000173c62ef4ddc5b21d9ec44ed Signed-off-by: Jeff Darcy Reviewed-on: https://review.gluster.org/17650 Smoke: Gluster Build System Tested-by: Jeff Darcy CentOS-regression: Gluster Build System Reviewed-by: Amar Tumballi Reviewed-by: Niels de Vos --- libglusterfs/src/refcount.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'libglusterfs/src/refcount.h') diff --git a/libglusterfs/src/refcount.h b/libglusterfs/src/refcount.h index 4ae37fecbfe..25f44258e42 100644 --- a/libglusterfs/src/refcount.h +++ b/libglusterfs/src/refcount.h @@ -26,7 +26,7 @@ typedef void (*gf_ref_release_t)(void *data); -struct _gf_ref_t { +struct _gf_ref { #ifdef REFCOUNT_NEEDS_LOCK gf_lock_t lk; /* lock for atomically adjust cnt */ #endif @@ -35,7 +35,7 @@ struct _gf_ref_t { gf_ref_release_t release; /* cleanup when cnt == 0 */ void *data; /* parameter passed to release() */ }; -typedef struct _gf_ref_t gf_ref_t; +typedef struct _gf_ref gf_ref_t; /* _gf_ref_get -- increase the refcount -- cgit