diff options
author | Bala Konda Reddy M <bala12352@gmail.com> | 2020-08-17 16:11:38 +0530 |
---|---|---|
committer | Bala Konda Reddy M <bala12352@gmail.com> | 2020-08-18 05:58:43 +0000 |
commit | 81440d1bab4d43785b37d285877b235ddd9ac6b6 (patch) | |
tree | 890ba5879f4188b4ee46ad897c443e1c55a7f903 /tests/functional/authentication/test_authentication_allow_blank.py | |
parent | 891472d8b77574dbb3346b98bb0948e0f2d12a2c (diff) |
[Testfix] Remove redundant logging - Part 1
Problem:
In most of the testcases due to redundant logging,
the performance of the whole suite completion time
is affected.
Solution:
Currently there are 100+ g.log.info statements in the
authentincation suite and half of them are redundant.
Removed the g.log.info statements whereever it is not
required. After the changes the g.log.info statements
are around 50 and not removed the statements to reduce
the number of lines but for the improvement of the
whole suite.
Modified few line indents as well and added teardown
for the missing files.
Note: Will be submitting for each components separately
Change-Id: I63973e115dd5dbbc7fc9462978397e7915181265
Signed-off-by: Bala Konda Reddy M <bala12352@gmail.com>
Diffstat (limited to 'tests/functional/authentication/test_authentication_allow_blank.py')
-rw-r--r-- | tests/functional/authentication/test_authentication_allow_blank.py | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/tests/functional/authentication/test_authentication_allow_blank.py b/tests/functional/authentication/test_authentication_allow_blank.py index dab0baab3..4bef00f31 100644 --- a/tests/functional/authentication/test_authentication_allow_blank.py +++ b/tests/functional/authentication/test_authentication_allow_blank.py @@ -28,8 +28,7 @@ from glustolibs.gluster.volume_libs import cleanup_volume @runs_on([['replicated', 'distributed-replicated', 'dispersed', - 'distributed-dispersed'], - ['glusterfs']]) + 'distributed-dispersed'], ['glusterfs']]) class AuthAllowEmptyString(GlusterBaseClass): """ Tests to verify auth.allow functionality on Volume and Fuse subdir @@ -38,13 +37,12 @@ class AuthAllowEmptyString(GlusterBaseClass): """ Setup Volume """ + # Calling GlusterBaseClass Setup + self.get_super_method(self, 'setUp')() + ret = self.setup_volume() if not ret: raise ExecutionError("Failed to setup volume") - g.log.info("Volume %s has been setup successfully", self.volname) - - # Calling GlusterBaseClass Setup - self.get_super_method(self, 'setUp')() def test_validate_authallow(self): """ @@ -76,5 +74,6 @@ class AuthAllowEmptyString(GlusterBaseClass): if not ret: raise ExecutionError("Failed to Cleanup the " "Volume %s" % self.volname) - g.log.info("Volume deleted successfully " - ": %s", self.volname) + + # Calling GlusterBaseClass tearDown + self.get_super_method(self, 'tearDown')() |