summaryrefslogtreecommitdiffstats
path: root/extras
Commit message (Collapse)AuthorAgeFilesLines
* quota_fsck.py fails with UnicodeDecodeErrorsrijan-sivakumar2020-09-161-5/+2
| | | | | | | | | | | | | | | | | | Issue: While decoding the byte characters the quota_fsck script stumbled across a corner case wherein the file names given by the getfattr dump will cause the decoding to UTF-8 to fail with UnicodeDecodeError. Code Change: On looking through the quota_fsck.py script, it seems like the file path is actually not needed when decoding for the xattr parsing, hence the code change reflects that. Also, removed a comparison which previously existed to skip the file names as that won't be required now. Fixes: #1487 Change-Id: I8a13ab07be6c9cfafae996f17764fbb4a285bd8c Signed-off-by: srijan-sivakumar <ssivakum@redhat.com>
* nfs-ganesha: gluster_shared_storage fails to automount on node reboot on rhel 8Shwetha K Acharya2020-09-103-3/+3
| | | | | | | | | | | | | | The patch https://review.gluster.org/#/c/glusterfs/+/24934/, changes mount point of gluster_shared_storage from /var/run to /run to address the issue of symlink at mount path in fstab. NOTE: mount point /var/run is symlink to /run The required changes with respect to gluster_shared_storage mount path are introduced with this patch in nfs-ganesha. Fixes: #1475 Change-Id: I9c7677a053e1291f71476d47ba6fa2e729f59625 Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
* extras/snap_scheduler: changes in gluster-shared-storage mount path Shwetha K Acharya2020-09-102-3/+3
| | | | | | | | | | | | | | The patch https://review.gluster.org/#/c/glusterfs/+/24934/, changes mount point of gluster_shared_storage from /var/run to /run to address the issue of symlink at mount path in fstab. NOTE: mount point /var/run is symlink to /run The required changes with respect to gluster_shared_storage mount path are introduced with this patch in snap_scheduler. Fixes: #1476 Change-Id: I9ce88c2f624c6aa5982de04edfee2d0a9f160d62 Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
* geo-rep: gluster_shared_storage fails to automount on node reboot on rhel 8.Shwetha K Acharya2020-09-101-10/+10
| | | | | | | | | | | | | | | | | | | | | | | | Issue: On reboot, all the mounts get wiped out. Only the mounts mentioned in /etc/fstab automatically gets mounted during boot/reboot. But /etc/fstab complains on not getting a canonical path (it gets path containing a symlink) This is because the gluster_shared_storage, is mounted to /var/run which is symlink to /run. This is a general practice followed by most operating systems. [root@ ~]# ls -lsah /var/run 0 lrwxrwxrwx. 1 root root 6 Jul 22 19:39 /var/run -> ../run Fix: Mount gluster_shared_storage on /run. (Also It is seen that /var/run is mostly used by old or legacy systems, thus it is a good practice to update /var/run to /run) fixes: #1459 Change-Id: I8c16653be8cd746c84f01abf0eea19284fb97c77 Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
* build: extend --enable-valgrind to support Memcheck and DRDDmitry Antipov2020-09-051-4/+8
| | | | | | | | | Extend '-enable-valgrind' to '--enable=valgrind[=memcheck,drd]' to enable Memcheck or DRD Valgrind tool, respectively. Change-Id: I80d13d72ba9756e0cbcdbeb6766b5c98e3e8c002 Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru> Updates: #1002
* Quota quota_fsck.py, converting byte string to stringsrijan-sivakumar2020-08-191-0/+1
| | | | | | | | | | | | | | Issue: The quota_fsck.py script throws an TypeError due to the fact that the data is read as bytes and then the string operations are applied on the. Now, in python3 string is unicode and hence we get the type error. Code Changes: Decoding the bytes value into utf-8 format. Change-Id: Ia1ff52a821d664a371c8166692ff506ae39f6e40 Signed-off-by: srijan-sivakumar <ssivakum@redhat.com> Fixes: #1401
* glusterd: shared storage mount fails in ipv6 environmentnik-redhat2020-08-181-1/+8
| | | | | | | | | | | | | | | | | Issue: In case of ipv6 environment, the mounting of glusterd_shared_storage volume fails as it doesn't recognises the ipv6 enviornment. Fix: In case of ipv6 environment, the address-family is passed to the hooks script on creating shared-storage, then depending upon the address-family --xlator-option=transport.address-family=inet6 option is added to the mount command, and the mounting succeeds. Fixes: #1406 Change-Id: Ib1888c34d85e6c01618b0ba214cbe1f57576908d Signed-off-by: nik-redhat <nladha@redhat.com>
* extras/statedumpparse.rb updatesCsaba Henk2020-07-251-59/+92
| | | | | | | | | | | | | - allow reusing JSON formatted output with --input-format=json - improve code readability - improve human readable number formatting - represent empty sections with {} rather than nil - add memstat subformats (plain, human, json) - make parsing of numerals more strict Updates: #1000 Change-Id: I75833543c85ad2b9c2233a4a22b1ea53d24431b9 Signed-off-by: Csaba Henk <csaba@redhat.com>
* extras/systemd: Move StartLimitIntervalSec to [Unit] sectionAnoop C S2020-06-191-1/+2
| | | | | | | | | | | | | | | | | | | | | | | It has been a while since systemd moved[1] StartLimitInterval= and StartLimitBurst= options(along with some others) from [Service] to [Unit] section. Additionally StartLimitInterval= got renamed[2] to StartLimitIntervalSec= and can be configured only in [Service] section. Therefore making necessary modifications to avoid following warning: $ sudo systemd-analyze verify glusterd.service /usr/local/lib/systemd/system/glusterd.service:21: Unknown key name 'StartLimitIntervalSec' in section 'Service', ignoring. For backward compatability reasons those options configured in [Service] section are also honoured but officially documented in man systemd.unit(5)[3]. [1] https://github.com/systemd/systemd/commit/6bf0f408e4833152197fb38fb10a9989c89f3a59 [2] https://github.com/systemd/systemd/commit/f0367da7d1a61ad698a55d17b5c28ddce0dc265a [3] https://www.freedesktop.org/software/systemd/man/systemd.unit.html Change-Id: I72a5b65930ddcf1d84c7e66f11685fa9a6fbda9a Updates: #1000 Signed-off-by: Anoop C S <anoopcs@redhat.com>
* extras: Modify group 'virt' to include network-related optionsKrutika Dhananjay2020-06-151-0/+5
| | | | | | | | | | | | This is needed to work around an issue seen where vms running on online hosts are getting killed when a different host is rebooted in ovirt-gluster hyperconverged environments. Actual RCA is quite lengthy and documented in the github issue. Please refer to it for more details. Change-Id: Ic25b5f50144ad42458e5c847e1e7e191032396c1 Fixes: #1217 Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
* common-ha: ganesha-ha.sh bad test for {rhel,centos} for pcs optionsKaleb S. KEITHLEY2020-05-281-1/+1
| | | | | | | | | | bash [[ ... =~ ... ]] built-in returns _0_ when the regex matches, not 1, thus the sense of the test is backwards and never correctly detects rhel or centos. Change-Id: Ic9e60aae4ea38aff8f13979080995e60621a68fe Fixes: #1269 Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
* common-ha: cluster status shows "FAILOVER" when actually HEALTHYKaleb S. KEITHLEY2020-05-041-2/+3
| | | | | | | | | | | | | | | | | | | | | | pacemaker devs change the format of the ouput of `pcs status` Expected to find a line in the format: Online: .... but now it's * Online: ... And the `grep -E "^Online:" no longer finds the list of nodes that are online. Also other lines now have '*' in first few characters of the line throwing off `grep -x ...` Change-Id: Ia04a89e76914f2a455a755f0a93fa415f60aefd0 Fixes: #1169 Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
* Use already expanded SYSCONF_DIR in glusterd.service instead of sysconfdirCharles Celerier2020-04-301-1/+1
| | | | | | | | | | | | | | | The generated glusterd.service file included the Automake artifact `${prefix}` in the EnvironmentFile definition. When an actual value for `${prefix}` is specified by Automake, this is not properly passed on to glusterd.service's EnvironmentFile variable since `${prefix}` will not be expanded once it is no longer in the control of Automake. Because this artifact was left by the sysconfdir variable, we substitute it with the SYSCONF_DIR variable that configure.ac expands earlier. Change-Id: I980b27590c15facb567b153bd57078fed320ff87 Updates: #1135 Signed-off-by: Charles Celerier <charles@chckyn.org>
* snapshot: fix python3 issue in gcronSunny Kumar2020-04-281-1/+2
| | | | | | | | | | | | | | | | | | | | | | `$gcron.py test_vol Job` Traceback: File "/usr/sbin/gcron.py", line 189, in <module> main() File "/usr/sbin/gcron.py", line 121, in main initLogger(script_name) File "/usr/sbin/gcron.py", line 44, in initLogger logfile = os.path.join(out.strip(), script_name[:-3]+".log") File "/usr/lib64/python3.6/posixpath.py", line 94, in join genericpath._check_arg_types('join', a, *p) File "/usr/lib64/python3.6/genericpath.py", line 151, in _check_arg_types raise TypeError("Can't mix strings and bytes in path components") from None TypeError: Can't mix strings and bytes in path components Solution: Added the 'universal_newlines' flag to Popen. Change-Id: I4c7a0e5bce605e4c134f6786c9dd8162b89fc77f Fixes: #1193 Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
* extras: upgrade script for geo-repShwetha K Acharya2020-04-271-0/+77
| | | | | | | | | | | | | | | | | The patch https://review.gluster.org/#/c/glusterfs/+/23733/( which optimizes the changelog) introduces change in dirctory structure which is above changelog files. Thus, before upgrade, old version should get updated, with respect to the corresponding changes made by the above qouted patch. This upgrade script, 1) creates a temp htime file, with updated paths from the htime file. Updates temp htime file as htime file. 2) places the changelog files under the required directory structure. Updates: #154 Change-Id: I4b5a6cb9a9266a65972b419b329bc958de8fdf8a Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
* common-ha: cluster status shows "FAILOVER" when actually HEALTHYKaleb S. KEITHLEY2020-04-141-1/+1
| | | | | | | | | | | | | | | | | | | pacemaker devs change the format of the ouput of `pcs status` Expected to find a line in the format: Online: .... but now it's * Online: ... And the `grep -E "^Online:" no longer finds the list of nodes that are online. Change-Id: If2aa1e7b53c766c625d7b4cc222a83ea2c0bd72d Fixes: #1169 Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
* snap_scheduler: python3 compatibility and new test caseSunny Kumar2020-04-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: "snap_scheduler.py init" command failing with the below traceback: [root@dhcp43-104 ~]# snap_scheduler.py init Traceback (most recent call last): File "/usr/sbin/snap_scheduler.py", line 941, in <module> sys.exit(main(sys.argv[1:])) File "/usr/sbin/snap_scheduler.py", line 851, in main initLogger() File "/usr/sbin/snap_scheduler.py", line 153, in initLogger logfile = os.path.join(process.stdout.read()[:-1], SCRIPT_NAME + ".log") File "/usr/lib64/python3.6/posixpath.py", line 94, in join genericpath._check_arg_types('join', a, *p) File "/usr/lib64/python3.6/genericpath.py", line 151, in _check_arg_types raise TypeError("Can't mix strings and bytes in path components") from None TypeError: Can't mix strings and bytes in path components Solution: Added the 'universal_newlines' flag to Popen to support backward compatibility. Added a basic test for snapshot scheduler. Change-Id: I78e8fabd866fd96638747ecd21d292f5ca074a4e Fixes: #1134 Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
* Updating create-ganesha-config script:Arjun Sharma2020-03-111-0/+1
| | | | | | | | Adding the Security_Label parameter for labelled nfs Change-Id: I26d332bc30c767093cfa5d6e63a3b0268fc8a60b Fixes: bz#1812353 Signed-off-by: Arjun Sharma <arjsharm@redhat.com>
* ganesha-ha: updates for pcs-0.10.x (i.e. in Fedora-29 and RHEL-8)Kaleb S. KEITHLEY2020-02-191-28/+56
| | | | | | | | | | | | | | pcs-0.10 has introduced changes options to pcs commands pcs-0.10.x is in Fedora-29 and later and RHEL-8. Also some minor cleanup. Namely use bash built-in [[...]] in a few more places instead of test(1), i.e. [...], and use correct "==" for comparison. Change-Id: I3fb2fcd71406964c77fdc4f18580ca133f365fd6 Fixes: bz#1193929 Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
* Be explicit on this being a python3 scriptMichael Scherer2020-01-161-1/+1
| | | | | | | | | | | | | While the script seems to work on both python3 and python2, this break the build of rawhide RPM who requires script to be either using python2 or python3. Since python2 is going to be deprecated, I guess we should aim for python3. Change-Id: Ic6322ad47772d708b60b96652a1122ee4a54141d Fixes: bz#1791682 Signed-off-by: Michael Scherer <misc@fedoraproject.org>
* glusterd: increase the StartLimitBurstSanju Rakonde2020-01-081-1/+1
| | | | | | | | | | Based on https://bugzilla.redhat.com/show_bug.cgi?id=1782200#c6 increasing the limit. fixes: bz#1782200 Change-Id: Ia885c7bdb2a90f0946c5268da894f6a4da5a69b7 Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
* [geo-rep] Improving help message in schedule_georep.py.inkshithijiyer2020-01-041-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | SLAVE positional argument doesn't provide a clear picture of what it is when compared to mastervol and slavevol in schedule_georep.py.in. It would be better if we change it to something like "Slave hostame (<username>@SLAVEHOST or SLAVEHOST)" Present: ---------- positional arguments: mastervol Master Volume Name SLAVE SLAVEHOST or root@SLAVEHOST or user@SLAVEHOST slavevol Slave Volume Name Suggested: ----------- positional arguments: mastervol Master Volume Name SLAVE Slave hostname (<username>@SLAVEHOST or SLAVEHOST) slavevol Slave Volume Name fixes: bz#1786276 Change-Id: I73d52247997d623f77d55e51cbb6eccc08eb95ff Signed-off-by: kshithijiyer <kshithij.ki@gmail.com>
* extras: enable log rotation for USS logsSunny Kumar2019-12-271-0/+21
| | | | | | | | Added logrotate support for user serviceable snapshot's logs. Change-Id: Ic920eaa8ab5e44daf5937a027c6913d7bb26d517 Fixes: bz#1786722 Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
* contributors: map domain names for CMSSXie Changlong2019-12-101-0/+1
| | | | | | updates: bz#1193929 Change-Id: Iaf1e1e3f787855ede1e94101ec0364084e534d61 Signed-off-by: Xie Changlong <xiechanglong@cmss.chinamobile.com>
* extras/hooks: Remove smb.conf parameter allowing guest accessAnoop C S2019-12-102-2/+0
| | | | | | Change-Id: I88f494f16153d27ab6e2f2faf4d557e075671b10 Fixes: bz#1775612 Signed-off-by: Anoop C S <anoopcs@redhat.com>
* cluster/ec: Scripts to find and reset files which can be healed.Ashish Pandey2019-12-103-0/+762
| | | | | | | | | | gfid_needing_heal_parallel.sh - Finds out if a file is healable or not. correct_pending_heals.sh - Makes necessary changes in xattrs to enable heal for those files which could be healed. fixes: #723 Change-Id: I38177888df0fda9486343ee546dc02836b06a5fc
* glusterd: start glusterd automatically on abnormal shutdownSanju Rakonde2019-12-051-0/+5
| | | | | | | | | | | | | | | | | If glusterd crashes or goes down abnormally, systemd should automatically bring the glusterd up. With this change, systemd brings glusterd up for atmost 3 times within time period of 1 hour. If the limit exceeds, we have to start the glusterd manually and reset the failure count using systemctl reset-failed. credits: John Strunk <jstrunk@redhat.com> fixes: bz#1776264 Change-Id: I312d243652fb13ba028814a2ea615b67e3b10b6a Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
* extras: fix the remote subvol name in case of thin-arbiterAmar Tumballi2019-11-162-4/+3
| | | | | | | | | * Also make sure to provide log-level in systemd file, instead of volfile itself. Updates: bz#1193929 Change-Id: I45a0b0ff3ebb4b3e095b4eed14b7bdf5816926d0 Signed-off-by: Amar Tumballi <amarts@gmail.com>
* extras: add statedumpparse.rbCsaba Henk2019-11-071-0/+175
| | | | | | | | | | | | | | | By default, the script mangles statedump records to JSON, which has two benefits: - easier machine processing - more friendly with line oriented tools, as one line will correspond to one record '--format=memstat' is also available which displays memory allocation types along the size of their allocations. Change-Id: I1685d3afcea6009fbcfafb33798f85bcd645c82f updates: bz#1193929 Signed-off-by: Csaba Henk <csaba@redhat.com>
* scripts: quota_fsck script TypeError: %d format:not dictHari Gowtham2019-11-061-2/+2
| | | | | | | | | | | Problem: One of the prints in the script have been using %i as the format for printing which doesn't work. Fix: use %s as the format in the place of %i Fixes: bz#1764129 Change-Id: I4480ede7bf62906ddedbe5f880a1e89c76946641 Signed-off-by: Hari Gowtham <hgowtham@redhat.com>
* extras: Cgroup(CPU/Mem) restriction are not working on gluster processMohit Agrawal2019-10-272-2/+2
| | | | | | | | | | | | | | Problem: After Configure the Cgroup(CPU/MEM) limit to a gluster processes resource(CPU/MEM) limits are not applicable to the gluster processes.Cgroup limits are not applicable because all threads are not moved into a newly created cgroup to apply restriction. Solution: To move a gluster thread to newly created cgroup change the condition in script Change-Id: I8ad81c69200e4ec43a74f6052481551cf835354c Fixes: bz#1764208 Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
* Scripts: quota_fsck script KeyError: 'contri_size'hari gowtham2019-10-221-6/+6
| | | | | | | | | | | | | Problem: In a certain code flow, we weren't handling the unavailability of the contri value in the dict. Trying to print without the value resulted in erroring out. Fix: Have printed the whole of dictionary as the values will be helpful in understanding the state of the file/dir Fixes: bz#1764129 Change-Id: I99c538adb712f281ca10e4e0088f404f515b9725 Signed-off-by: hari gowtham <hgowtham@redhat.com>
* extras: Enable direct-io options in group virtKrutika Dhananjay2019-10-081-1/+2
| | | | | | | | | | | | | Direct-io options are currently enabled in the ovirt-gluster installation through cockpit ui whereas all the other optimizations in gluster for virt are enabled through the group-virt option using 'volume-set' command. For the sake of completeness and to avoid any confusion, it would be better to set the o-direct gluster options also as part of group virt. Change-Id: Iac4c443c2a8239effeb05a52344e563f1d877916 Fixes: bz#1758984 Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
* geo-rep: Fix spelling errorsShwetha K Acharya2019-09-241-1/+1
| | | | | | Fixes: bz#1741779 Change-Id: I708b6b7e6c520dee10445528e6f99ba38e141c25 Signed-off-by: Shwetha K Acharya <sacharya@redhat.com>
* [Doc] Fixing 404 links in markdown files.kshithijiyer2019-09-051-1/+1
| | | | | | | | | | | | | | | | | | | | Problem: While running markdown-link-checker it was observed that there were a large number of 404 links present in the documentation present in the form of markdown files in the project. This was casued due to the following reasons: 1. Repos being removed. 2. Typo in markdown links. 3. Restructring of directoires. Solution: Fixing all the 404 links present in the project. fixes: bz#1746810 Change-Id: I30de745f848fca2e9c92eb7493f74738f0890ed9 Signed-off-by: kshithijiyer <kshithij.ki@gmail.com>
* peer_map parameter and fix in state detection when no brick is running on peerJiri Lunacek2019-08-301-0/+22
| | | | | | | | | The resource agent assumed that peer names in gluster are identical to short hostname of the machine which is not always the case. This commit adds a parameter to solve this. Also resource agent reported brick running on cluster nodes that did not cary any brick of specified volume. Change-Id: I90aacfc34ac0d00aae3f2abb69cacd7278b886bc Fixes: bz#1737778 Signed-off-by: Jiri Lunacek <jiri.lunacek@hosting90.cz>
* build: move arch-dependent files from /usr/share to /usr/libexecSheetal Pamecha2019-08-301-1/+1
| | | | | | | | | | All architecture-dependent data should be placed in /usr/libexec, and architecture independent data files in /usr/share. fixes: bz#1387404 Change-Id: Ie3249cae37c5ee4211309ef55a7a76682e57602f Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
* glusterd: glusterd service is getting timed out on scaled setupMohit Agrawal2019-08-281-0/+1
| | | | | | | | | | | Problem: On a three node cluster with 2000 replica volumes systemctl is getting timed out for glusted service. Solution: Configure TimeoutSec 300 to wait for glusterd startup. Change-Id: Idb3f3f3e56e6216a0ebd754cbb9e8e37ce9e636d Fixes: bz#1746228 Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
* Revert "glusterd: (storhaug) remove ganesha (843e1b0)"Jiffin Tony Thottan2019-08-242-16/+25
| | | | | | | | | please note as an additional change, macro GLUSTERD_GET_SNAP_DIR moved from glusterd-store.c to glusterd-snapshot-utils.h Change-Id: I811efefc148453fe32e4f0d322e80455447cec71 updates: #663 Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
* Revert "packaging: (ganesha) remove glusterfs-ganesha subpackage and related ↵Jiffin Tony Thottan2019-08-2415-2/+2159
| | | | | | | | | | | | | | | | | | | files" Until 3.12, glusterd had an option to setup HA cluster for nfs-ganesha using pacemaker and corosync. But later infavour of "Storhaug" Project, this functionality was removed from the codebase. Since there is not much development happening towards storhaug, it better to keep back old working HA solution for nfs-ganesha with bit improvements. Planned improvements : * add an option in nfs-ganesha enable to set ganesha without HA. * Handle usage of export id's properly in the scripts. Change-Id: I1d60c8970bfc20035cf674d7b2705dfd4819647e updates: #663 Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
* gluster-smb:add smb parameter when access gluster by cifsyinkui2019-08-212-0/+2
| | | | | | Change-Id: I9ff54f2ca6f86bb5b2f4740485a0159e1fd7785f Fixes: bz#1741734 Signed-off-by: yinkui <13965432176@163.com>
* extras/mount-shared-storage.sh: consider options to mountMPLX2019-07-231-1/+1
| | | | | | | | | If different mount options are given to glusterfs in /etc/fstab, it was not considered in the script. Fixes: bz#1690454 Change-Id: If829b3d6ab79755647626edcb31f38a3716989db Signed-off-by: Amar Tumballi <amarts@redhat.com>
* gluster-block: tuning perf optionsPrasanna Kumar Kalever2019-07-231-0/+8
| | | | | | | | | | As per the perf experiment run by Elvir, with NVME devices used for OCP (gluster) it was seen that particularly read operations (read/randread) benefited from these options. Change-Id: Ibec4b96afd28e6f7e757b6ef203ccdbc0d9854d5 Fixes: bz#1727852 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
* ibverbs/rdma: remove from buildAmar Tumballi2019-07-131-2/+1
| | | | | | | | | | | | | | | We have proposed about this an year ago, and with recent smoke failures, it looks like the right time to take such call. ref: https://lists.gluster.org/pipermail/gluster-users/2018-July/034400.html With this, glusterfs-8.0 wouldn't have rdma feature, and would allow some modularity changes possible with rpc layer (as we would have just 1 transport) Updates: bz#1635688 Change-Id: Ia277dca4d4b1f0cffae20819024a52b075b775e5 Signed-off-by: Amar Tumballi <amarts@redhat.com>
* fix template file after clang-formatAmar Tumballi2019-06-202-39/+37
| | | | | | | | | | | clang-format gets applied for all the files ending with .c or .h but in this case, new-xlator.c was a template file. hence change the suffix to reflect the same, also to avoid the auto-formatting on template file. updates: bz#1193929 Change-Id: I1c00a28f165f34dbe00fd3b6b070d868a56f9157 Signed-off-by: Amar Tumballi <amarts@redhat.com>
* encryption/crypt: remove from volume fileAmar Tumballi2019-06-201-1/+0
| | | | | | | | | | | | | | The feature is not supported and is moved out of the codebase from glusterfs-5.x release. Doesn't make sense to keep the code to support it. For those who want to upgrade from an version supporting it to higher version, please do a 'gluster volume reset $VOL encryption reset' and then continue with the upgrade process. updates: bz#1648169 Change-Id: I8cf822c0d7195940bd37f6af2432a3cac68d44d1 Signed-off-by: Amar Tumballi <amarts@redhat.com>
* extras/hooks: Install and package newly added post add-brick hook scriptAnoop C S2019-06-191-2/+2
| | | | | | | | | | | | https://review.gluster.org/c/glusterfs/+/22834 added a new SELinux hook script as a post add-brick operation to label new brick paths. But the change failed to install and package new script. Therefore making necessary changes to Makefile and spec file to get it installed and packaged. Change-Id: I67b8f4982c2783c34a4bc749fb4387c19a038225 fixes: bz#1717953 Signed-off-by: Anoop C S <anoopcs@redhat.com>
* eventsapi: Fix Exception class for Python3Aravinda VK2019-06-141-1/+8
| | | | | | | | | | | | | | | Python2 exception provides message attribute for custom exceptions. But it is not available in Python3. Add init method for custom exception to handle the same. Original crash(IndexError reported in the bug) was fixed with https://review.gluster.org/#/c/glusterfs/+/22294/ But that patch only works in Python2 and fails in Python3 since Exception in Python 3 doesn't have "message" attribute. Fixes: bz#1573226 Change-Id: If9117048f9ff0615f5da1880075ec12c0ff4855e Signed-off-by: Aravinda VK <avishwan@redhat.com>
* extras/hooks: Add SELinux label on new bricks during add-brickAnoop C S2019-06-121-0/+100
| | | | | | Change-Id: Ifd8ae5eeb91b968cc1a9a9b5d15844c5233d56db fixes: bz#1717953 Signed-off-by: Anoop C S <anoopcs@redhat.com>
* cluster/replicate: Modify command in unit file to assign port correctlyAshish Pandey2019-06-082-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: In unit file of TA process we have been using ta-vol as volume id and also ta-vol-server.transport.socket.listen-port=24007 In volume file for TA process we only consider volname as "ta" and not as "ta-vol". That's why it was not able to assign this port number to ta process as in volume file it will try to find server xlator as ta-vol volume ta-server <<<<<<<<< not ta-vol-server 46 type protocol/server 47 option transport.listen-backlog 10 48 option transport.socket.keepalive-count 9 49 option transport.socket.keepalive-interval 2 50 option transport.socket.keepalive-time 20 51 option transport.tcp-user-timeout 0 52 option transport.socket.keepalive 1 53 option auth.addr./mnt/thin-arbiter.allow * 54 option auth-path /mnt/thin-arbiter 55 option transport.address-family inet 56 option transport-type tcp 57 subvolumes ta-io-stats 58 end-volume Solution: Provide "ta" as vol id for the command which Unit file is going to execute. Also, made changes in setup-thin-arbiter.sh to correctly identify the directory of Unit file irrespective of the location from where we are executing this script. Change-Id: Ia7bbccdc0304e7dfaaa732bebb726fba731d1d33 fixes: bz#1716766 Signed-off-by: Ashish Pandey <aspandey@redhat.com>