summaryrefslogtreecommitdiffstats
path: root/xlators
diff options
context:
space:
mode:
authorMichael Scherer <misc@redhat.com>2017-02-19 11:06:56 +0100
committerShyamsundar Ranganathan <srangana@redhat.com>2017-02-24 09:52:45 -0500
commitff2ba49d02dc99b0c3de5712348ae9d588be7ad7 (patch)
tree6f38131e3b941ab99d3d8f4417728b65715d888e /xlators
parentf08f5bfef923259fe6de6d41a0a2b1b9140fc547 (diff)
Filter coverty false positives
Since random is not used for anything cryptographically related, it is fine to use it in those instances. Change-Id: I720172285f60d6bc477c7169c7286fc018ebdf8f BUG: 1424764 Signed-off-by: Michael Scherer <misc@redhat.com> Reviewed-on: https://review.gluster.org/16668 Smoke: Gluster Build System <jenkins@build.gluster.org> Tested-by: Nigel Babu <nigelb@redhat.com> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org> CentOS-regression: Gluster Build System <jenkins@build.gluster.org> Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Diffstat (limited to 'xlators')
-rw-r--r--xlators/cluster/dht/src/tier.c1
-rw-r--r--xlators/debug/error-gen/src/error-gen.c2
-rw-r--r--xlators/features/locks/src/common.c1
3 files changed, 4 insertions, 0 deletions
diff --git a/xlators/cluster/dht/src/tier.c b/xlators/cluster/dht/src/tier.c
index 4103274..b13c41c 100644
--- a/xlators/cluster/dht/src/tier.c
+++ b/xlators/cluster/dht/src/tier.c
@@ -445,6 +445,7 @@ tier_do_migration (xlator_t *this, int promote)
migrate = promote ? 0 : 1;
break;
case TIER_WM_MID:
+ /* coverty[DC.WEAK_CRYPTO] */
rand = random() % 100;
if (promote) {
migrate = (rand > tier_conf->percent_full);
diff --git a/xlators/debug/error-gen/src/error-gen.c b/xlators/debug/error-gen/src/error-gen.c
index b6b17ba..103c302 100644
--- a/xlators/debug/error-gen/src/error-gen.c
+++ b/xlators/debug/error-gen/src/error-gen.c
@@ -178,6 +178,7 @@ generate_rand_no (int op_no)
int rand_no = 0;
if (op_no < GF_FOP_MAXVALUE)
+ /* coverty[DC.WEAK_CRYPTO] */
rand_no = rand () % error_no_list[op_no].error_no_count;
return rand_no;
}
@@ -367,6 +368,7 @@ error_gen (xlator_t *this, int op_no)
ret = error_no_list[op_no].error_no[rand_no];
}
if (egp->random_failure == _gf_true)
+ /* coverty[DC.WEAK_CRYPTO] */
egp->failure_iter_no = 3 + (rand () % GF_UNIVERSAL_ANSWER);
}
return ret;
diff --git a/xlators/features/locks/src/common.c b/xlators/features/locks/src/common.c
index 8cdff0d..68f253d 100644
--- a/xlators/features/locks/src/common.c
+++ b/xlators/features/locks/src/common.c
@@ -1129,6 +1129,7 @@ pl_does_monkey_want_stuck_lock()
long int monkey_unlock_rand = 0;
long int monkey_unlock_rand_rem = 0;
+ /* coverty[DC.WEAK_CRYPTO] */
monkey_unlock_rand = random ();
monkey_unlock_rand_rem = monkey_unlock_rand % 100;
if (monkey_unlock_rand_rem == 0)