diff options
author | Niels de Vos <ndevos@redhat.com> | 2015-07-17 10:16:54 +0200 |
---|---|---|
committer | Raghavendra Bhat <raghavendra@redhat.com> | 2015-07-23 03:03:02 -0700 |
commit | a28d161733e670d264999c6f486915bf738a7bfd (patch) | |
tree | ec04de78166b418cd420b934f81102a30d00e2df /xlators | |
parent | 6263e73688ba2be49fd55f4c6a2d12609ce45f91 (diff) |
nfs: a unix-domain-socket should not be created as fifo
Cherry picked from commit 381afd4f480533f212e1f62a0ccfd9dcf7248e17:
> Change-Id: Ic6a23165df1703b330636a059967c3c674dbde57
> BUG: 1235231
> Signed-off-by: Niels de Vos <ndevos@redhat.com>
> Reviewed-on: http://review.gluster.org/11355
> Tested-by: NetBSD Build System <jenkins@build.gluster.org>
> Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
> Tested-by: Gluster Build System <jenkins@build.gluster.com>
Change-Id: Ic6a23165df1703b330636a059967c3c674dbde57
BUG: 1244117
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/11709
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Diffstat (limited to 'xlators')
-rw-r--r-- | xlators/nfs/server/src/nfs3.c | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/xlators/nfs/server/src/nfs3.c b/xlators/nfs/server/src/nfs3.c index 7ecfc675b61..2df775abb5c 100644 --- a/xlators/nfs/server/src/nfs3.c +++ b/xlators/nfs/server/src/nfs3.c @@ -3030,7 +3030,7 @@ rpcerr: } -int +static int nfs3_mknod_reply (rpcsvc_request_t *req, nfsstat3 stat, struct nfs3_fh *fh, struct iatt *buf, struct iatt *preparent, struct iatt *postparent) @@ -3126,7 +3126,7 @@ nfs3err: } -int +static int nfs3_mknod_device (nfs3_call_state_t *cs) { int ret = -EFAULT; @@ -3157,12 +3157,11 @@ nfs3_mknod_device (nfs3_call_state_t *cs) } -int -nfs3_mknod_fifo (nfs3_call_state_t *cs) +static int +nfs3_mknod_fifo (nfs3_call_state_t *cs, mode_t mode) { int ret = -EFAULT; nfs_user_t nfu = {0, }; - mode_t mode = S_IFIFO; if (!cs) return ret; @@ -3181,7 +3180,7 @@ nfs3_mknod_fifo (nfs3_call_state_t *cs) } -int +static int nfs3_mknod_resume (void *carg) { nfsstat3 stat = NFS3ERR_SERVERFAULT; @@ -3200,8 +3199,10 @@ nfs3_mknod_resume (void *carg) ret = nfs3_mknod_device (cs); break; case NF3SOCK: + ret = nfs3_mknod_fifo (cs, S_IFSOCK); + break; case NF3FIFO: - ret = nfs3_mknod_fifo (cs); + ret = nfs3_mknod_fifo (cs, S_IFIFO); break; default: ret = -EBADF; |