summaryrefslogtreecommitdiffstats
path: root/xlators
diff options
context:
space:
mode:
authorAmar Tumballi <amarts@redhat.com>2012-04-17 23:30:23 +0530
committerVijay Bellur <vijay@gluster.com>2012-04-18 06:25:39 -0700
commit7522df3b98467c2ddfb9cc12f5c807d4408267cc (patch)
tree906d889ae963764955b77be5a33219ed66f48d6a /xlators
parent7ef32ae76d1c1e4a5ff47899d175be9fdeb73bc8 (diff)
glusterd (remove-brick): fix data-loss issue
* when more than one brick (more than one distribute subvolume) was removed using single command, rebalance process used to get started only on one node, causing data-loss when 'commit' was done, because the brick's data was not migrated at all. Fixed the logic of validating rebalance required in remove- brick case. Change-Id: I3a90ff9f9593e5215110a3a0974bb97e7271f910 Signed-off-by: Amar Tumballi <amarts@redhat.com> BUG: 812770 Reviewed-on: http://review.gluster.com/3173 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Jeff Darcy <jdarcy@redhat.com> Reviewed-by: Shishir Gowda <shishirng@gluster.com>
Diffstat (limited to 'xlators')
-rw-r--r--xlators/mgmt/glusterd/src/glusterd-brick-ops.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-brick-ops.c b/xlators/mgmt/glusterd/src/glusterd-brick-ops.c
index 9754049..4bb6c51 100644
--- a/xlators/mgmt/glusterd/src/glusterd-brick-ops.c
+++ b/xlators/mgmt/glusterd/src/glusterd-brick-ops.c
@@ -1563,7 +1563,7 @@ glusterd_op_remove_brick (dict_t *dict, char **op_errstr)
}
ret = glusterd_op_perform_remove_brick (volinfo, brick, force,
- (i == 1) ? &need_rebalance : NULL);
+ &need_rebalance);
if (ret)
goto out;
i++;