summaryrefslogtreecommitdiffstats
path: root/xlators
diff options
context:
space:
mode:
authorRaghavendra G <rgowdapp@redhat.com>2018-07-14 18:17:47 +0530
committerRaghavendra G <rgowdapp@redhat.com>2018-08-02 17:43:11 +0530
commit74b63639e81a4e674600993cfbec619c61857c35 (patch)
tree5e3465d9ff73aa7453e981c8d2d46f75013d2135 /xlators
parent47cbe34db67be7bfbf925b3d76bb25d48b9ed680 (diff)
performance/open-behind: don't use anonymous fds for reads by default
anonymous fds interfere with working of read-ahead as read-ahead won't be able to store its cache in fd. Also, as seen in bz 1455872, anonymous fds also affect performance of large file sequential reads as the cost of opening fd for each read on brick stack is significant. So, have a proper fd which enables read-ahead to store its cache and brick stack to reuse the fd during reads. With this change test tests/bugs/snapshot/bug-1167580-set-proper-uid-and-gid-during-nfs-access.t fails consistently. The failure can also be seen with open-behind off. bz 1611532 has been filed to track the issue with test. Thanks to Rafi <rkavunga@redhat.com> for assistance provided in debugging test failure. Change-Id: Ifa52d8ff017f115e83247f3396b9d27f0295ce3f Signed-off-by: Raghavendra G <rgowdapp@redhat.com> Fixes: bz#1455872
Diffstat (limited to 'xlators')
-rw-r--r--xlators/performance/open-behind/src/open-behind.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/xlators/performance/open-behind/src/open-behind.c b/xlators/performance/open-behind/src/open-behind.c
index 19943ebe841..396bf29f40e 100644
--- a/xlators/performance/open-behind/src/open-behind.c
+++ b/xlators/performance/open-behind/src/open-behind.c
@@ -1096,7 +1096,7 @@ struct volume_options options[] = {
},
{ .key = {"read-after-open"},
.type = GF_OPTION_TYPE_BOOL,
- .default_value = "no",
+ .default_value = "yes",
.description = "read is sent only after actual open happens and real "
"fd is obtained, instead of doing on anonymous fd (similar to write)",
.op_version = {3},