coverity: Ignore most of SECURE_TEMP issues

mkstemp as per the Linux man page, uses 0600 as the permission
bits when creating the file. This is hence safe and a Coverity
warning that should be ignored.

Further, we are mostly a multi-threaded program in all our daemons
and cannot set and unset umask at will in a multi-threaded
program, to address the coverity issue.

This change attempts to nudge coverity to ignore this warning,
using the pattern,
/* coverity[EVENT_TAG_NAME] ... */
<line of code that has the issue>

This commit is an experiment, if post merge the next coverity
report ignores these errors, the above pattern (as found using
an internet search) works and can be applied to certain other
warnings as well.

Change-Id: I73a184ce1a54dd9e66542952b1190a74438c826a
Updates: bz#789278
Signed-off-by: ShyamsundarR <srangana@redhat.com>

4 files changed, 6 insertions, 0 deletions

diff --git a/xlators/cluster/ec/src/ec-code.c b/xlators/cluster/ec/src/ec-code.c
index 2cdd5bebe11..e33cb42d9dc 100644
--- a/xlators/cluster/ec/src/ec-code.c
+++ b/xlators/cluster/ec/src/ec-code.c
@@ -417,6 +417,7 @@ ec_code_space_create(ec_code_t *code, size_t size)
 
         /* We need to create a temporary file as the backend storage for the
          * memory mapped areas. */
+        /* coverity[secure_temp] mkstemp uses 0600 as the mode and is safe */
         fd = mkstemp(path);
         if (fd < 0) {
                 err = errno;
diff --git a/xlators/mgmt/glusterd/src/glusterd-gfproxyd-svc-helper.c b/xlators/mgmt/glusterd/src/glusterd-gfproxyd-svc-helper.c
index 7098ae27eaf..781cdbf6818 100644
--- a/xlators/mgmt/glusterd/src/glusterd-gfproxyd-svc-helper.c
+++ b/xlators/mgmt/glusterd/src/glusterd-gfproxyd-svc-helper.c
@@ -101,6 +101,7 @@ glusterd_svc_get_gfproxyd_volfile (glusterd_volinfo_t *volinfo, char *svc_name,
 
         snprintf (tmpvol, path_len, "/tmp/g%s-XXXXXX", svc_name);
 
+        /* coverity[secure_temp] mkstemp uses 0600 as the mode and is safe */
         tmp_fd = mkstemp (tmpvol);
         if (tmp_fd < 0) {
                 gf_msg ("glusterd", GF_LOG_WARNING, errno,
diff --git a/xlators/mgmt/glusterd/src/glusterd-svc-helper.c b/xlators/mgmt/glusterd/src/glusterd-svc-helper.c
index 14c2fce5353..abf979eada5 100644
--- a/xlators/mgmt/glusterd/src/glusterd-svc-helper.c
+++ b/xlators/mgmt/glusterd/src/glusterd-svc-helper.c
@@ -180,6 +180,7 @@ glusterd_svc_check_volfile_identical (char *svc_name,
 
         snprintf (tmpvol, sizeof (tmpvol), "/tmp/g%s-XXXXXX", svc_name);
 
+        /* coverity[secure_temp] mkstemp uses 0600 as the mode and is safe */
         tmp_fd = mkstemp (tmpvol);
         if (tmp_fd < 0) {
                 gf_msg (this->name, GF_LOG_WARNING, errno,
@@ -231,6 +232,7 @@ glusterd_svc_check_topology_identical (char *svc_name,
 
         /* Create the temporary volfile */
         snprintf (tmpvol, sizeof (tmpvol), "/tmp/g%s-XXXXXX", svc_name);
+        /* coverity[secure_temp] mkstemp uses 0600 as the mode and is safe */
         tmpfd = mkstemp (tmpvol);
         if (tmpfd < 0) {
                 gf_msg (this->name, GF_LOG_WARNING, errno,
diff --git a/xlators/mgmt/glusterd/src/glusterd-tierd-svc-helper.c b/xlators/mgmt/glusterd/src/glusterd-tierd-svc-helper.c
index 42cf8968429..8b54ac10594 100644
--- a/xlators/mgmt/glusterd/src/glusterd-tierd-svc-helper.c
+++ b/xlators/mgmt/glusterd/src/glusterd-tierd-svc-helper.c
@@ -105,6 +105,7 @@ glusterd_svc_check_tier_volfile_identical (char *svc_name,
 
         snprintf (tmpvol, sizeof (tmpvol), "/tmp/g%s-XXXXXX", svc_name);
 
+        /* coverity[secure_temp] mkstemp uses 0600 as the mode and is safe */
         tmp_fd = mkstemp (tmpvol);
         if (tmp_fd < 0) {
                 gf_msg (this->name, GF_LOG_WARNING, errno,
@@ -158,6 +159,7 @@ glusterd_svc_check_tier_topology_identical (char *svc_name,
 
         snprintf (tmpvol, sizeof (tmpvol), "/tmp/g%s-XXXXXX", svc_name);
 
+        /* coverity[secure_temp] mkstemp uses 0600 as the mode and is safe */
         tmpfd = mkstemp (tmpvol);
         if (tmpfd < 0) {
                 gf_msg (this->name, GF_LOG_WARNING, errno,