summaryrefslogtreecommitdiffstats
path: root/xlators/system
diff options
context:
space:
mode:
authorHomma <homma@allworks.co.jp>2019-07-05 16:10:41 +0530
committerjiffin tony Thottan <jthottan@redhat.com>2019-07-16 04:43:31 +0000
commit6bf9637a93011298d032332ca93009ba4e377e46 (patch)
tree207f08b62e009671998a2632176703ce806d1c0f /xlators/system
parent30f54b702a82c45a31aeb58fabe5b79fb62cc37b (diff)
system/posix-acl: update ctx only if iatt is non-NULL
We need to safe-guard against possible zero'ing out of iatt structure in acl ctx, which can cause many issues. fixes: bz#1668286 Change-Id: Ie81a57d7453a6624078de3be8c0845bf4d432773 Signed-off-by: Amar Tumballi <amarts@redhat.com>
Diffstat (limited to 'xlators/system')
-rw-r--r--xlators/system/posix-acl/src/posix-acl.c8
1 files changed, 8 insertions, 0 deletions
diff --git a/xlators/system/posix-acl/src/posix-acl.c b/xlators/system/posix-acl/src/posix-acl.c
index cd8d5e5..77c8df5 100644
--- a/xlators/system/posix-acl/src/posix-acl.c
+++ b/xlators/system/posix-acl/src/posix-acl.c
@@ -873,6 +873,13 @@ posix_acl_ctx_update(inode_t *inode, xlator_t *this, struct iatt *buf,
int ret = 0;
int i = 0;
+ if (!buf || !buf->ia_ctime) {
+ /* No need to update ctx if buf is empty */
+ gf_log_callingfn(this->name, GF_LOG_DEBUG, "iatt struct is empty (%d)",
+ fop);
+ goto out;
+ }
+
LOCK(&inode->lock);
{
ctx = __posix_acl_ctx_get(inode, this, _gf_true);
@@ -926,6 +933,7 @@ posix_acl_ctx_update(inode_t *inode, xlator_t *this, struct iatt *buf,
}
unlock:
UNLOCK(&inode->lock);
+out:
return ret;
}