diff options
| author | Hari Gowtham <hgowtham@redhat.com> | 2015-07-10 11:27:26 +0530 |
|---|---|---|
| committer | Pranith Kumar Karampuri <pkarampu@redhat.com> | 2015-09-01 21:35:05 -0700 |
| commit | c817aa4734063500888c2d1ea5ee0c6fd5d4e405 (patch) | |
| tree | 655a039d21a51a74a455a75d9a9cf226e5361c3c /xlators/storage | |
| parent | 7dd0667d46bc32f9180a0bb381d1eef7cab2a947 (diff) | |
posix.c posix-helpers.c: porting new log messages
Backport of review.gluster.org/#/c/11609/
> Change-Id: I0c306d796ff49263d8a6c191b24a41da8a21bd2c
> BUG: 1252695
> Signed-off-by: Hari Gowtham <hgowtham@redhat.com>
Change-Id: I0c306d796ff49263d8a6c191b24a41da8a21bd2c
BUG: 1258736
Signed-off-by: Hari Gowtham <hgowtham@redhat.com>
Reviewed-on: http://review.gluster.org/12074
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Diffstat (limited to 'xlators/storage')
| -rw-r--r-- | xlators/storage/posix/src/posix-helpers.c | 2 | ||||
| -rw-r--r-- | xlators/storage/posix/src/posix.c | 12 |
2 files changed, 7 insertions, 7 deletions
diff --git a/xlators/storage/posix/src/posix-helpers.c b/xlators/storage/posix/src/posix-helpers.c index 082e74eb6f5..0d81e9a644a 100644 --- a/xlators/storage/posix/src/posix-helpers.c +++ b/xlators/storage/posix/src/posix-helpers.c @@ -518,8 +518,6 @@ posix_fdstat (xlator_t *this, int fd, struct iatt *stbuf_p) iatt_from_stat (&stbuf, &fstatbuf); ret = posix_fill_gfid_fd (this, fd, &stbuf); - if (ret) - gf_log_callingfn (this->name, GF_LOG_DEBUG, "failed to get gfid"); posix_fill_ino_from_gfid (this, &stbuf); diff --git a/xlators/storage/posix/src/posix.c b/xlators/storage/posix/src/posix.c index cafe565c321..63439d3f707 100644 --- a/xlators/storage/posix/src/posix.c +++ b/xlators/storage/posix/src/posix.c @@ -2793,8 +2793,9 @@ _fill_writev_xdata (fd_t *fd, dict_t *xdata, xlator_t *this, int is_append) inode = fd->inode; if (!fd || !fd->inode || gf_uuid_is_null (fd->inode->gfid)) { - gf_log_callingfn (this->name, GF_LOG_ERROR, "Invalid Args: " - "fd: %p inode: %p gfid:%s", fd, inode?inode:0, + gf_msg_callingfn (this->name, GF_LOG_ERROR, EINVAL, + P_MSG_XATTR_FAILED, "fd: %p inode: %p" + "gfid:%s", fd, inode?inode:0, inode?uuid_utoa(inode->gfid):"N/A"); goto out; } @@ -4548,9 +4549,10 @@ posix_fsetxattr (call_frame_t *frame, xlator_t *this, if (xdata && dict_get (xdata, DHT_IATT_IN_XDATA_KEY)) { ret = posix_fdstat (this, pfd->fd, &stbuf); if (ret == -1) { - gf_log (this->name, GF_LOG_ERROR, - "fsetxattr (fstat) failed on fd=%p: %s", - fd, strerror (op_errno)); + op_errno = errno; + gf_msg (this->name, GF_LOG_ERROR, op_errno, + P_MSG_XATTR_FAILED, "fsetxattr (fstat)" + "failed on fd=%p", fd); goto out; } |