diff options
| author | Kaleb S KEITHLEY <kkeithle@redhat.com> | 2015-11-18 12:28:42 -0500 |
|---|---|---|
| committer | Niels de Vos <ndevos@redhat.com> | 2016-01-18 01:02:34 -0800 |
| commit | 50ae3e67e4f294925fc840d3f83b77f7072af54d (patch) | |
| tree | d682399e0b506b09d3106ea69c0518ea6cd8e0d8 /xlators/storage | |
| parent | f3e03c9d47b7438a6f124e01e2f459c2b72b1c29 (diff) | |
all: reduce "inline" usage
There are three kinds of inline functions: plain inline, extern inline,
and static inline. All three have been removed from .c files, except
those in "contrib" which aren't our problem. Inlines in .h files, which
are overwhelmingly "static inline" already, have generally been left
alone. Over time we should be able to "lower" these into .c files, but
that has to be done in a case-by-case fashion requiring more manual
effort. This part was easy to do automatically without (as far as I can
tell) any ill effect.
In the process, several pieces of dead code were flagged by the
compiler, and were removed.
backport of Change-Id: I56a5e614735c9e0a6ee420dab949eac22e25c155,
http://review.gluster.org/11769, BUG: 1245331
Change-Id: Iba1efb0bc578ea4a5e9bf76b7bd93dc1be9eba44
BUG: 1283302
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/12646
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Diffstat (limited to 'xlators/storage')
| -rw-r--r-- | xlators/storage/bd/src/bd-helper.c | 2 | ||||
| -rw-r--r-- | xlators/storage/posix/src/posix.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/xlators/storage/bd/src/bd-helper.c b/xlators/storage/bd/src/bd-helper.c index 8aaffa6b27a..23bd46bf85e 100644 --- a/xlators/storage/bd/src/bd-helper.c +++ b/xlators/storage/bd/src/bd-helper.c @@ -569,7 +569,7 @@ out: return ret; } -inline void +void bd_update_amtime(struct iatt *iatt, int flag) { struct timespec ts = {0, }; diff --git a/xlators/storage/posix/src/posix.c b/xlators/storage/posix/src/posix.c index 380b5b676dc..8132f57ffdb 100644 --- a/xlators/storage/posix/src/posix.c +++ b/xlators/storage/posix/src/posix.c @@ -3225,7 +3225,7 @@ _handle_setxattr_keyvalue_pair (dict_t *d, char *k, data_t *v, } #ifdef GF_DARWIN_HOST_OS -static inline int +static int map_xattr_flags(int flags) { /* DARWIN has different defines on XATTR_ flags. |