path: root/xlators/storage/posix/src/posix-messages.h
diff options
authorRaghavendra Bhat <>2016-03-14 15:10:17 -0400
committerRaghavendra G <>2016-03-26 09:33:48 -0700
commit06d50c1c00fe35c6bc2192a392b8a749984f3efc (patch)
treef9bd6219e456b3b580e7ff8b2a0ec3973161fd2c /xlators/storage/posix/src/posix-messages.h
parent351ec36e3146b7605334cb658927b447b1dbc796 (diff)
storage/posix: send proper iatt attributes for the root inode
* changes in posix to send proper iatt attributes for the root directory when ancestry is built. Before posix was filling only the gfid and the inode type in the iatt structure keeping rest of the fields zeros. This was cached by posix-acl and used to send EACCES when some fops came on that object if the uid of the caller is same as the uid of the object on the disk. * getting and setting inode_ctx in function 'posix_acl_ctx_get' is not atomic and can lead to memory leak when there are multiple looups for an inode at same time. This patch fix this problem * Linking an inode in posix_build_ancestry, can cause a race in posix_acl. When parent inode is linked in posix_build_ancestry, and before it reaches posix_acl_readdirp_cbkc, reate/lookup can come on a leaf-inode, as parent-inode-ctx not yet updated in posix_acl_readdirp_cbk, create/lookup can fail with EACCESS. So do the inode linking in the quota xlator Change-Id: I3101eefb65551cc4162c4ff2963be1b73deacd6d BUG: 1320818 Signed-off-by: Raghavendra Bhat <> Reviewed-on: Tested-by: Vijaikumar Mallikarjuna <> Smoke: Gluster Build System <> NetBSD-regression: NetBSD Build System <> CentOS-regression: Gluster Build System <> Reviewed-by: Raghavendra G <>
Diffstat (limited to 'xlators/storage/posix/src/posix-messages.h')
1 files changed, 9 insertions, 1 deletions
diff --git a/xlators/storage/posix/src/posix-messages.h b/xlators/storage/posix/src/posix-messages.h
index ad16c1d..4efdef0 100644
--- a/xlators/storage/posix/src/posix-messages.h
+++ b/xlators/storage/posix/src/posix-messages.h
@@ -45,7 +45,7 @@
-#define GLFS_NUM_MESSAGES 107
+#define GLFS_NUM_MESSAGES 108
/* Messaged with message IDs */
#define glfs_msg_start_x POSIX_COMP_BASE, "Invalid: Start of messages"
@@ -917,6 +917,14 @@
+ * @messageid
+ * @diagnosis
+ * @recommendedaction
+ *
+ */
#define glfs_msg_end_x GLFS_MSGID_END, "Invalid: End of messages"