path: root/xlators/protocol
diff options
authorPranith Kumar K <>2019-05-27 11:43:26 +0530
committerAmar Tumballi <>2019-05-30 15:54:33 +0000
commit14d9c6179715205fb6ac816d4621dd087f5afbb2 (patch)
treed8f94f2d0461c975d57c53860508b012c870742d /xlators/protocol
parentd2576452028db3b817fc5b1f4f924a98bc22c7dc (diff)
stack: Make sure to have unique call-stacks in all cases
At the moment new stack doesn't populate frame->root->unique in all cases. This makes it difficult to debug hung frames by examining successive state dumps. Fuse and server xlators populate it whenever they can, but other xlators won't be able to assign 'unique' when they need to create a new frame/stack because they don't know what 'unique' fuse/server xlators already used. What we need is for unique to be correct. If a stack with same unique is present in successive statedumps, that means the same operation is still in progress. This makes 'finding hung frames' part of debugging hung frames easier. fixes bz#1714098 Change-Id: I3e9a8f6b4111e260106c48a2ac3a41ef29361b9e Signed-off-by: Pranith Kumar K <>
Diffstat (limited to 'xlators/protocol')
1 files changed, 0 insertions, 3 deletions
diff --git a/xlators/protocol/server/src/server-helpers.c b/xlators/protocol/server/src/server-helpers.c
index f6edf3f..5ffd5d2 100644
--- a/xlators/protocol/server/src/server-helpers.c
+++ b/xlators/protocol/server/src/server-helpers.c
@@ -456,7 +456,6 @@ server_alloc_frame(rpcsvc_request_t *req)
frame->root->client = client;
frame->root->state = state; /* which socket */
- frame->root->unique = 0; /* which call */
frame->this = client->this;
@@ -484,8 +483,6 @@ get_frame_from_request(rpcsvc_request_t *req)
frame->root->op = req->procnum;
- frame->root->unique = req->xid;
client = req->trans->xl_private;
this = req->trans->xl;
priv = this->private;