path: root/xlators/protocol/auth
diff options
authorKaleb S. KEITHLEY <>2018-09-11 14:17:02 -0400
committerShyamsundar Ranganathan <>2018-09-12 14:38:13 +0000
commitf15e948da3881b61a8b546af7c64340db87d3cf7 (patch)
tree1d62049561f23371c00ddfa0069cba8e5da8d89a /xlators/protocol/auth
parentd9475b8d06ca184b5305575e5f04490604f8ca2c (diff)
build: cleanup xlator link, --no-undefined, libuuidv6dev
While attempting to build a (pre-)5.0 of glusterfs on Ubuntu bionic and cosmic, it became apparent that there are some gremlins hiding in the combination of the xlator export-symbols, the newish addition of -Wl,--no-undefined, and the new switch to libuuid from the old contrib/uuid. Note: even though Fedora 28 (and later) and Ubuntu bionic (and later) have the same nominal version of libtool, the Fedora version appears to do a better job of recursing through dependencies to determine the libraries to link with. Examination of the build logs showed that despite appearing to work on Fedora, not all xlators and shared libs were linked with -Wl, --no-undefined, and -luuid. And in the case of the gnfs xlator, it was not only not linked with -Wl,--no-undefined but alsos not linked with -lgfxdr and -lgfrpc. Added GF_XLATOR_LDFLAGS, similar to GF_XLATOR_DEFAULT_LDFLAGS. GF_XLATOR_DEFAULT_LDFLAGS is for xlators that export/expose the default or common set of symbols. GF_XLATOR_LDFLAGS is for those remaining xlators that export/expose non-default symbols, e.g. dht and glupy. This removes the need in the future to add things like $(UUID_LIBS) to every xlator's Just add it to GF_XLATOR_LDFLAGS and GF_XLATOR_DEFAULT_LDFLAGS in and you're done. This patch was tested on Fedora 28 (build, rpmbuild), Fedora Rawhide/30 (rpmbuild), RHEL8 (rpmbuild), CentOS7 (rpmbuild), Fedora koji --scratch build for f30/rawhide, and a Launchpad build for Ubuntu cosmic/18.10. Change-Id: Ieca104fa5c5d3c094e701c8ca4a73754dd0292b0 updates: bz#1193929 Signed-off-by: Kaleb S. KEITHLEY <>
Diffstat (limited to 'xlators/protocol/auth')
2 files changed, 2 insertions, 2 deletions
diff --git a/xlators/protocol/auth/addr/src/ b/xlators/protocol/auth/addr/src/
index 6c8834d3e3e..4694d254f12 100644
--- a/xlators/protocol/auth/addr/src/
+++ b/xlators/protocol/auth/addr/src/
@@ -1,7 +1,7 @@
authdir = $(libdir)/glusterfs/$(PACKAGE_VERSION)/auth
-addr_la_LDFLAGS = -module -avoid-version
+addr_la_LDFLAGS = -module $(GF_XLATOR_LDFLAGS)
addr_la_SOURCES = addr.c
addr_la_LIBADD = $(top_builddir)/libglusterfs/src/
diff --git a/xlators/protocol/auth/login/src/ b/xlators/protocol/auth/login/src/
index fd4b2d731b2..9837437b11e 100644
--- a/xlators/protocol/auth/login/src/
+++ b/xlators/protocol/auth/login/src/
@@ -1,7 +1,7 @@
authdir = $(libdir)/glusterfs/$(PACKAGE_VERSION)/auth
-login_la_LDFLAGS = -module -avoid-version
+login_la_LDFLAGS = -module $(GF_XLATOR_LDFLAGS)
login_la_SOURCES = login.c
login_la_LIBADD = $(top_builddir)/libglusterfs/src/