summaryrefslogtreecommitdiffstats
path: root/xlators/nfs/server/src
diff options
context:
space:
mode:
authorAmar Tumballi <amarts@redhat.com>2018-12-06 16:24:52 +0530
committerAmar Tumballi <amarts@redhat.com>2018-12-13 14:41:50 +0530
commitaf7e957b4954bd84b8f7df6bfbd59c939092ead2 (patch)
treeadee47b6e02a44f5ba3f722d767dca929ccbd9c1 /xlators/nfs/server/src
parent088e2cbb5ee3f3e766b7e4021e2d86d0c5187de0 (diff)
xlator: make 'xlator_api' mandatory
* Remove the options to load old symbol. * keep only 'xlator_api' symbol from being exported using xlator.sym * add xlator_api to all the xlators where its missing NOTE: This covers all the xlators which has at least a test case to validate its loading. If there is a translator, which doesn't have any test, then we should probably remove that from codebase. fixes: #164 Change-Id: Ibcdc8c9844cda6b4463d907a15813745d14c1ebb Signed-off-by: Amar Tumballi <amarts@redhat.com>
Diffstat (limited to 'xlators/nfs/server/src')
-rw-r--r--xlators/nfs/server/src/nfs.c19
-rw-r--r--xlators/nfs/server/src/nfsserver.sym10
2 files changed, 18 insertions, 11 deletions
diff --git a/xlators/nfs/server/src/nfs.c b/xlators/nfs/server/src/nfs.c
index ceb4943..3dbe3c7 100644
--- a/xlators/nfs/server/src/nfs.c
+++ b/xlators/nfs/server/src/nfs.c
@@ -1529,7 +1529,7 @@ notify(xlator_t *this, int32_t event, void *data, ...)
return 0;
}
-int
+void
fini(xlator_t *this)
{
struct nfs_state *nfs = NULL;
@@ -1539,7 +1539,7 @@ fini(xlator_t *this)
gf_msg_debug(GF_NFS, 0, "NFS service going down");
nfs_deinit_versions(&nfs->versions, this);
GF_FREE(this->instance_name);
- return 0;
+ return;
}
int32_t
@@ -2040,3 +2040,18 @@ struct volume_options options[] = {
},
{.key = {NULL}},
};
+
+xlator_api_t xlator_api = {
+ .init = init,
+ .fini = fini,
+ .notify = notify,
+ .reconfigure = reconfigure,
+ .mem_acct_init = mem_acct_init,
+ .op_version = {1},
+ .dumpops = &dumpops,
+ .fops = &fops,
+ .cbks = &cbks,
+ .options = options,
+ .identifier = "gnfs",
+ .category = GF_MAINTAINED,
+};
diff --git a/xlators/nfs/server/src/nfsserver.sym b/xlators/nfs/server/src/nfsserver.sym
index 2126634..dce7d96 100644
--- a/xlators/nfs/server/src/nfsserver.sym
+++ b/xlators/nfs/server/src/nfsserver.sym
@@ -1,12 +1,3 @@
-init
-fini
-fops
-cbks
-options
-notify
-mem_acct_init
-reconfigure
-dumpops
exp_file_parse
exp_file_print
exp_file_get_dir
@@ -18,3 +9,4 @@ ng_file_parse
ng_file_get_netgroup
ng_file_print
ng_file_deinit
+xlator_api