diff options
author | Mohammed Rafi KC <rkavunga@redhat.com> | 2016-01-12 12:13:15 +0530 |
---|---|---|
committer | Rajesh Joseph <rjoseph@redhat.com> | 2016-02-22 21:33:29 -0800 |
commit | a8d19874e95519198d305283e7a58ecc64947e07 (patch) | |
tree | 00abf6ab415b2d3abe541d57430ba80f8d7159f2 /xlators/features/snapview-client/src | |
parent | 3f1fba83ad6b077318f85888fafdfb483a62b98e (diff) |
snapview-client: remove check for parent inode type
In lookup call back path, we are checking for parent inode
type to make sure parent inode was set properly, so that
next op on the inode can be successfuly completed.
More info can be found at bugid 1297311
Back port of>
>Change-Id: Ifb1b17f472f855f9b12088c3dd8328389d895e77
>BUG: 1297311
>Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
>Reviewed-on: http://review.gluster.org/13227
>Reviewed-by: Avra Sengupta <asengupt@redhat.com>
>Tested-by: NetBSD Build System <jenkins@build.gluster.org>
>Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Change-Id: I347aa0e42ae35491246747dee50724fc91964611
BUG: 1306131
Signed-off-by: Mohammed Rafi KC <rkavunga@redhat.com>
Reviewed-on: http://review.gluster.org/13412
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Diffstat (limited to 'xlators/features/snapview-client/src')
-rw-r--r-- | xlators/features/snapview-client/src/snapview-client.c | 26 |
1 files changed, 0 insertions, 26 deletions
diff --git a/xlators/features/snapview-client/src/snapview-client.c b/xlators/features/snapview-client/src/snapview-client.c index 3df327e9c13..19d06f8d65a 100644 --- a/xlators/features/snapview-client/src/snapview-client.c +++ b/xlators/features/snapview-client/src/snapview-client.c @@ -269,11 +269,9 @@ svc_lookup_cbk (call_frame_t *frame, void *cookie, xlator_t *this, struct iatt *buf, dict_t *xdata, struct iatt *postparent) { svc_local_t *local = NULL; - inode_t *parent = NULL; xlator_t *subvolume = NULL; gf_boolean_t do_unwind = _gf_true; int inode_type = -1; - int parent_type = -1; int ret = -1; local = frame->local; @@ -335,27 +333,6 @@ svc_lookup_cbk (call_frame_t *frame, void *cookie, xlator_t *this, goto out; } - if (local->loc.parent) - parent = inode_ref (local->loc.parent); - else { - parent = inode_parent (inode, NULL, NULL); - if (!parent && !gf_uuid_is_null (local->loc.pargfid)) { - parent = inode_find (inode->table, - local->loc.pargfid); - } - } - - if (!__is_root_gfid (buf->ia_gfid) && parent) { - ret = svc_inode_ctx_get (this, parent, &parent_type); - if (ret < 0) { - op_ret = -1; - op_errno = EINVAL; - gf_log (this->name, GF_LOG_WARNING, - "Error fetching parent context"); - goto out; - } - } - if (subvolume == FIRST_CHILD (this)) inode_type = NORMAL_INODE; else @@ -372,9 +349,6 @@ out: xdata, postparent); } - if (parent) - inode_unref (parent); - return 0; } |