summaryrefslogtreecommitdiffstats
path: root/xlators/features/compress/src
diff options
context:
space:
mode:
authorHarpreet Lalwani <hlalwani@redhat.com>2018-09-24 14:53:18 +0530
committerAmar Tumballi <amarts@redhat.com>2018-10-05 00:09:54 +0000
commit3be7116d39ff767a24e5206de584a3c5f3afe8ef (patch)
tree0d0d99a104d062c2d83565d3dd32b5ef3d306f5a /xlators/features/compress/src
parent2066466dadf658dcf7226267ada50faaa103b7f3 (diff)
features/compress: NULL pointer dereferencing clang fix
Added a Label "err" to avoid NULL pointer dereferencing Updates: bz#1622665 Change-Id: I7ec02a9cbbc482c2cf77f66e5692e86cd251cd53 Signed-off-by: Harpreet Lalwani <hlalwani@redhat.com>
Diffstat (limited to 'xlators/features/compress/src')
-rw-r--r--xlators/features/compress/src/cdc.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/xlators/features/compress/src/cdc.c b/xlators/features/compress/src/cdc.c
index 25ea6dc1846..adace6bcca8 100644
--- a/xlators/features/compress/src/cdc.c
+++ b/xlators/features/compress/src/cdc.c
@@ -118,8 +118,8 @@ cdc_writev(call_frame_t *frame, xlator_t *this, fd_t *fd, struct iovec *vector,
};
size_t isize = 0;
- GF_VALIDATE_OR_GOTO("cdc", this, default_out);
- GF_VALIDATE_OR_GOTO(this->name, frame, default_out);
+ GF_VALIDATE_OR_GOTO("cdc", this, err);
+ GF_VALIDATE_OR_GOTO(this->name, frame, err);
priv = this->private;
@@ -167,6 +167,9 @@ default_out:
FIRST_CHILD(this)->fops->writev, fd, vector, count, offset,
flags, iobref, xdata);
return 0;
+err:
+ STACK_UNWIND_STRICT(writev, frame, -1, EINVAL, NULL, NULL, NULL);
+ return 0;
}
int32_t