all: reduce "inline" usage

There are three kinds of inline functions: plain inline, extern inline,
and static inline.  All three have been removed from .c files, except
those in "contrib" which aren't our problem.  Inlines in .h files, which
are overwhelmingly "static inline" already, have generally been left
alone.  Over time we should be able to "lower" these into .c files, but
that has to be done in a case-by-case fashion requiring more manual
effort.  This part was easy to do automatically without (as far as I can
tell) any ill effect.

In the process, several pieces of dead code were flagged by the
compiler, and were removed.

backport of Change-Id: I56a5e614735c9e0a6ee420dab949eac22e25c155,
http://review.gluster.org/11769, BUG: 1245331

Change-Id: Iba1efb0bc578ea4a5e9bf76b7bd93dc1be9eba44
BUG: 1283302
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/12646
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>

2 files changed, 2 insertions, 53 deletions

diff --git a/xlators/features/changelog/lib/src/gf-changelog-reborp.c b/xlators/features/changelog/lib/src/gf-changelog-reborp.c
index 2a1e56ae79e..19c43cc8211 100644
--- a/xlators/features/changelog/lib/src/gf-changelog-reborp.c
+++ b/xlators/features/changelog/lib/src/gf-changelog-reborp.c
@@ -87,55 +87,6 @@ gf_changelog_connection_janitor (void *arg)
         return NULL;
 }
 
-static inline void
-__gf_changelog_set_conn_state (gf_changelog_t *entry,
-                               gf_changelog_conn_state_t state)
-{
-        entry->connstate = state;
-}
-
-/**
- * state check login to gaurd access object after free
- */
-static inline void
-gf_changelog_check_event (gf_private_t *priv,
-                          gf_changelog_t *entry, rpcsvc_event_t event)
-{
-        gf_boolean_t needfree = _gf_false;
-        gf_changelog_conn_state_t laststate;
-        /**
-         * need to handle couple of connection states to gaurd correct
-         * freeing of object.
-         */
-        LOCK (&entry->statelock);
-        {
-                laststate = entry->connstate;
-                if (event == RPCSVC_EVENT_ACCEPT) {
-                        __gf_changelog_set_conn_state
-                                (entry, GF_CHANGELOG_CONN_STATE_ACCEPTED);
-
-                        if (laststate == GF_CHANGELOG_CONN_STATE_DISCONNECTED)
-                                needfree = _gf_true;
-                }
-
-                if (event == RPCSVC_EVENT_DISCONNECT) {
-                        __gf_changelog_set_conn_state
-                                (entry, GF_CHANGELOG_CONN_STATE_DISCONNECTED);
-
-                        if (laststate == GF_CHANGELOG_CONN_STATE_ACCEPTED)
-                                needfree = _gf_true;
-                }
-        }
-        UNLOCK (&entry->statelock);
-
-        /**
-         * TODO:
-         * Handle the  race between ACCEPT and DISCONNECT in the
-         * reconnect code. So purging of entry is deliberately
-         * avoided here. It will be handled in the reconnect code.
-         */
-}
-
 int
 gf_changelog_reborp_rpcsvc_notify (rpcsvc_t *rpc, void *mydata,
                                    rpcsvc_event_t event, void *data)
@@ -173,8 +124,6 @@ gf_changelog_reborp_rpcsvc_notify (rpcsvc_t *rpc, void *mydata,
                 break;
         }
 
-        /* gf_changelog_check_event (priv, entry, event); */
-
         return 0;
 }
 
@@ -230,7 +179,7 @@ gf_changelog_invoke_callback (gf_changelog_t *entry,
  * dynamically allocated and ordered.
  */
 
-inline int
+int
 __is_expected_sequence (struct gf_event_list *ev, struct gf_event *event)
 {
         return (ev->next_seq == event->seq);
diff --git a/xlators/features/changelog/lib/src/gf-changelog.c b/xlators/features/changelog/lib/src/gf-changelog.c
index bc953369343..c528a24f017 100644
--- a/xlators/features/changelog/lib/src/gf-changelog.c
+++ b/xlators/features/changelog/lib/src/gf-changelog.c
@@ -44,7 +44,7 @@
  */
 xlator_t *master = NULL;
 
-static inline
+static
 gf_private_t *gf_changelog_alloc_priv ()
 {
         int ret = 0;