path: root/xlators/features/bit-rot/src/stub/bit-rot-stub.c
diff options
authorRavishankar N <>2017-04-02 18:08:04 +0530
committerPranith Kumar Karampuri <>2017-04-18 22:29:25 -0400
commit10dad995c989e9d77c341135d7c48817baba966c (patch)
treebe377c185b2bdaa186d7d534b26d14e7d0765c5f /xlators/features/bit-rot/src/stub/bit-rot-stub.c
parent43695cfba3bcbb53d7127128e37a724862f65017 (diff)
afr: don't do a post-op on a brick if op failed
Problem: In afr-v2, self-blaming xattrs are not there by design. But if the FOP failed on a brick due to an error other than ENOTCONN (or even due to ENOTCONN, but we regained connection before postop was wound), we wind the post-op also on the failed brick, leading to setting self-blaming xattrs on that brick. This can lead to undesired results like healing of files in split-brain etc. Fix: If a fop failed on a brick on which pre-op was successful, do not perform post-op on it. This also produces the desired effect of not resetting the dirty xattr on the brick, which is how it should be because if the fop failed on a brick, there is no reason to clear the dirty bit which actually serves as an indication of the failure. Change-Id: I5f1caf4d1b39f36cf8093ccef940118638caa9c4 BUG: 1438255 Signed-off-by: Ravishankar N <> Reviewed-on: Smoke: Gluster Build System <> NetBSD-regression: NetBSD Build System <> CentOS-regression: Gluster Build System <> Reviewed-by: Pranith Kumar Karampuri <>
Diffstat (limited to 'xlators/features/bit-rot/src/stub/bit-rot-stub.c')
0 files changed, 0 insertions, 0 deletions