path: root/xlators/debug
diff options
authorJeff Darcy <>2015-07-28 12:11:12 -0400
committerJeff Darcy <>2015-09-01 04:55:15 -0700
commit0773ca67fdb60a142207759fa6c07a69882ce59c (patch)
tree027101fce644fe17e58c78321b1632f38aaed166 /xlators/debug
parent038dfe57cf0c5944b0392332dbf5a00bb1208150 (diff)
all: reduce "inline" usage
There are three kinds of inline functions: plain inline, extern inline, and static inline. All three have been removed from .c files, except those in "contrib" which aren't our problem. Inlines in .h files, which are overwhelmingly "static inline" already, have generally been left alone. Over time we should be able to "lower" these into .c files, but that has to be done in a case-by-case fashion requiring more manual effort. This part was easy to do automatically without (as far as I can tell) any ill effect. In the process, several pieces of dead code were flagged by the compiler, and were removed. Change-Id: I56a5e614735c9e0a6ee420dab949eac22e25c155 BUG: 1245331 Signed-off-by: Jeff Darcy <> Reviewed-on: Tested-by: NetBSD Build System <> Reviewed-by: Dan Lambright <> Reviewed-by: Kaleb KEITHLEY <> Reviewed-by: Niels de Vos <> Reviewed-by: Raghavendra Bhat <> Reviewed-by: Venky Shankar <>
Diffstat (limited to 'xlators/debug')
2 files changed, 3 insertions, 3 deletions
diff --git a/xlators/debug/io-stats/src/io-stats.c b/xlators/debug/io-stats/src/io-stats.c
index be47202a4f3..68a2dfc6360 100644
--- a/xlators/debug/io-stats/src/io-stats.c
+++ b/xlators/debug/io-stats/src/io-stats.c
@@ -150,7 +150,7 @@ struct ios_local {
struct volume_options options[];
-inline static int
+static int
is_fop_latency_started (call_frame_t *frame)
GF_ASSERT (frame);
@@ -510,7 +510,7 @@ out:
return 0;
-static inline int
+static int
ios_stats_cleanup (xlator_t *this, inode_t *inode)
diff --git a/xlators/debug/trace/src/trace.c b/xlators/debug/trace/src/trace.c
index 94d32a70cca..5bbd07ad32a 100644
--- a/xlators/debug/trace/src/trace.c
+++ b/xlators/debug/trace/src/trace.c
@@ -19,7 +19,7 @@
#define TRACE_STAT_TO_STR(buf, str) trace_stat_to_str (buf, str, sizeof (str))
-static inline void
+static void
trace_stat_to_str(struct iatt *buf, char *str, size_t len)
char atime_buf[256] = {0,};