path: root/xlators/debug/trace
diff options
authorAmar Tumballi <>2018-11-01 07:25:25 +0530
committerShyamsundar Ranganathan <>2018-11-05 18:50:59 +0000
commit74e8328d3f6901d6ba38a313965fe910c8411324 (patch)
tree4816063d412cf9e436da301fccf165485bf22e18 /xlators/debug/trace
parent2effe3b0d3fa51fc627c970353de2e326bcf1ef2 (diff)
all: fix the format string exceptions
Currently, there are possibilities in few places, where a user-controlled (like filename, program parameter etc) string can be passed as 'fmt' for printf(), which can lead to segfault, if the user's string contains '%s', '%d' in it. While fixing it, makes sense to make the explicit check for such issues across the codebase, by making the format call properly. Fixes: CVE-2018-14661 Fixes: bz#1644763 Change-Id: Ib547293f2d9eb618594cbff0df3b9c800e88bde4 Signed-off-by: Amar Tumballi <>
Diffstat (limited to 'xlators/debug/trace')
1 files changed, 2 insertions, 2 deletions
diff --git a/xlators/debug/trace/src/trace.c b/xlators/debug/trace/src/trace.c
index ad8ca088777..0aca3a9a5bb 100644
--- a/xlators/debug/trace/src/trace.c
+++ b/xlators/debug/trace/src/trace.c
@@ -77,7 +77,7 @@ dump_history_trace(circular_buffer_t *cb, void *data)
".%" GF_PRI_SUSECONDS, cb->tv.tv_usec);
gf_proc_dump_write("TIME", "%s", timestr);
- gf_proc_dump_write("FOP", "%s\n", cb->data);
+ gf_proc_dump_write("FOP", "%s\n", (char *)cb->data);
return 0;
@@ -3218,7 +3218,7 @@ trace_dump_history(xlator_t *this)
// Is it ok to return silently if log-history option his off?
if (conf && conf->log_history == _gf_true) {
gf_proc_dump_build_key(key_prefix, "xlator.debug.trace", "history");
- gf_proc_dump_add_section(key_prefix);
+ gf_proc_dump_add_section("%s", key_prefix);
eh_dump(this->history, NULL, dump_history_trace);
ret = 0;