diff options
| author | Pranith Kumar K <pkarampu@redhat.com> | 2018-02-28 17:58:31 +0530 |
|---|---|---|
| committer | jiffin tony Thottan <jthottan@redhat.com> | 2018-08-17 05:34:35 +0000 |
| commit | dfbc7eaa8258721670a66fc49df7774cb248ff4f (patch) | |
| tree | 561ea41458c9b56e0bb3860ebd7d56795e3665b7 /xlators/cluster/afr/src/afr.h | |
| parent | 4fc27a7e3022088dbadedb5c2a83b94ae52e1766 (diff) | |
cluster/afr: Fix dict-leak in pre-op
At the time of pre-op, pre_op_xdata is populted with the xattrs we get from the
disk and at the time of post-op it gets over-written without unreffing the
previous value stored leading to a leak.
This is a regression we missed in
https://review.gluster.org/#/q/ba149bac92d169ae2256dbc75202dc9e5d06538e
Originally:
> Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
> (cherry picked from commit e7b79c59590c203c65f7ac8548b30d068c232d33)
Change-Id: I0456f9ad6f77ce6248b747964a037193af3a3da7
Fixes: bz#1613512
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Diffstat (limited to 'xlators/cluster/afr/src/afr.h')
| -rw-r--r-- | xlators/cluster/afr/src/afr.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/xlators/cluster/afr/src/afr.h b/xlators/cluster/afr/src/afr.h index 91825aa94ea..db6f61eb4bd 100644 --- a/xlators/cluster/afr/src/afr.h +++ b/xlators/cluster/afr/src/afr.h @@ -748,8 +748,8 @@ typedef struct _afr_local { unsigned char *pre_op; - /* For arbiter configuration only. */ - dict_t **pre_op_xdata; + /* Changelog xattr dict for [f]xattrop*/ + dict_t **changelog_xdata; unsigned char *pre_op_sources; /* @failed_subvols: subvolumes on which a pre-op or a |