diff options
| author | Mohit Agrawal <moagrawa@redhat.com> | 2016-10-03 10:55:23 +0530 |
|---|---|---|
| committer | Niels de Vos <ndevos@redhat.com> | 2016-10-14 03:45:27 -0700 |
| commit | 5faa744eafed0b603e7ad421953465be4b74b79c (patch) | |
| tree | 0d4df6c68dc82ae9635c1d106875b62a9c1900fe /rpc | |
| parent | 5ebbd9525699214c56b90b7ee3b389edb06cf98a (diff) | |
rpc/socket.c : Modify gf_log message in socket_poller code in case of error
Problem: In case of SSL after stopping the volume if client(mount point) is
still trying to write the data on socket then it will throw an EIO
error on that socket and given this log message is captured at every
attempt this would flood the log file.
Solution: To reduce the frequency of stored log message use GF_LOG_OCCASIONALLY
instead of gf_log.
> BUG: 1381115
> Change-Id: I66151d153c2cbfb017b3ebc4c52162278c0f537c
> Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
> Reviewed-on: http://review.gluster.org/15605
> Smoke: Gluster Build System <jenkins@build.gluster.org>
> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
> CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
> Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
> (cherry picked from commit 070145750006c87099f945b4990a4460d814c21f)
Change-Id: I08a8a8ae66b80bba2fdb5afbcab19a0950f85104
BUG: 1384356
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Reviewed-on: http://review.gluster.org/15631
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Diffstat (limited to 'rpc')
| -rw-r--r-- | rpc/rpc-transport/socket/src/socket.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/rpc/rpc-transport/socket/src/socket.c b/rpc/rpc-transport/socket/src/socket.c index f13d9b7f26e..700157ea240 100644 --- a/rpc/rpc-transport/socket/src/socket.c +++ b/rpc/rpc-transport/socket/src/socket.c @@ -2409,7 +2409,7 @@ out: return ret; } - +static int poll_err_cnt; static void * socket_poller (void *ctx) { @@ -2545,8 +2545,11 @@ socket_poller (void *ctx) break; } if (ret < 0 && errno != ENODATA) { - gf_log(this->name,GF_LOG_ERROR, - "error in polling loop"); + GF_LOG_OCCASIONALLY (poll_err_cnt, this->name, + GF_LOG_ERROR, + "socket_poller %s failed (%s)", + this->peerinfo.identifier, + strerror (errno)); break; } if (priv->ot_gen != gen) { |