path: root/rpc/rpc-lib/src/protocol-common.h
diff options
authorMohit Agrawal <>2017-01-13 12:17:05 +0530
committerNiels de Vos <>2017-01-16 01:32:13 -0800
commitafdd83a9b69573b854e732795c0bcba0a00d6c0f (patch)
treed3fff9461fa8e62dc72a037ef737f008c9e6b413 /rpc/rpc-lib/src/protocol-common.h
parent2041fb7872fa6672e9164fd2a12aaf80e6ef3ebd (diff)
upcall: Resolve dict leak from up_(f)removexattr in upcall code path
Problem: In up_(f)removexattr() dict_for_key_value() is used to create a new dict. This dict is not correctly unref'd and gets leaked. Solution: To avoid the leak up_(f)removexattr() now also does a dict_unref() on the newly created dict. While reviewing the code in up_(f)setxattr() for a similar problem, it was noticed that there is an extra dict created. There is no need for this copy, upcall_local_init() can just take the dict that was passed as argument to the FOP. BUG: 1412917 Change-Id: I5bb9a7d99f5087af11c19ae722de62bdb5ad1498 Signed-off-by: Mohit Agrawal <> Reviewed-on: NetBSD-regression: NetBSD Build System <> CentOS-regression: Gluster Build System <> Reviewed-by: Niels de Vos <> Smoke: Gluster Build System <>
Diffstat (limited to 'rpc/rpc-lib/src/protocol-common.h')
0 files changed, 0 insertions, 0 deletions