summaryrefslogtreecommitdiffstats
path: root/libglusterfs
diff options
context:
space:
mode:
authorHarshavardhana <fharshav@redhat.com>2012-01-03 16:05:51 -0800
committerVijay Bellur <vijay@gluster.com>2012-01-12 21:47:06 -0800
commitfaf9099bb50d4d2c1a9fe8d3232d541b3f68bc58 (patch)
tree3276d9f6b7dfd6724d40db75c36ec0d7634b09aa /libglusterfs
parent718a2744076ff21d19c0e9b2cadac5b975a3f6a9 (diff)
cluster/distribute: dht_aggregate() fix a logic error before xattr comparisons
Change-Id: I20f015263bed9851225005d5f41a5d518bd22592 BUG: 769691 Signed-off-by: Harshavardhana <fharshav@redhat.com> Reviewed-on: http://review.gluster.com/2557 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Amar Tumballi <amar@gluster.com>
Diffstat (limited to 'libglusterfs')
-rw-r--r--libglusterfs/src/dict.c9
1 files changed, 6 insertions, 3 deletions
diff --git a/libglusterfs/src/dict.c b/libglusterfs/src/dict.c
index 833f117..fd9dd1c 100644
--- a/libglusterfs/src/dict.c
+++ b/libglusterfs/src/dict.c
@@ -108,9 +108,12 @@ int32_t
is_data_equal (data_t *one,
data_t *two)
{
- /* LOG-TODO */
- if (!one || !two || !one->data || !two->data)
- return 1;
+ if (!one || !two || !one->data || !two->data) {
+ gf_log_callingfn ("dict", GF_LOG_ERROR,
+ "input arguments are provided "
+ "with value data_t as NULL");
+ return -1;
+ }
if (one == two)
return 1;