summaryrefslogtreecommitdiffstats
path: root/libglusterfs
diff options
context:
space:
mode:
authorSanju Rakonde <srakonde@redhat.com>2018-06-08 19:39:58 +0530
committerAtin Mukherjee <amukherj@redhat.com>2018-06-13 15:34:08 +0000
commit87f392e7fa22c059a95ff58f1653a285afc0f27a (patch)
tree2aace442cc505fdcd5c63c7b5c69e1e60501c6df /libglusterfs
parent8e63ca9bba888df0965f0beeed51a5336e6cb8cd (diff)
glusterd: Fix for shd not coming up
Problem: After creating and starting n(n is large) distribute-replicated volumes using a script, if we create and start (n+1)th distribute-replicate volume manually self heal daemon is down. Solution: In glusterd_proc_stop after giving SIGTERM signal if the process is still running, we are giving a SIGKILL. As SIGKILL will not perform any cleanup process, we need to remove the pidfile. Fixes: bz#1589253 Change-Id: I7c114334eec74c8d0f21b3e45cf7db6b8ef28af1 Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
Diffstat (limited to 'libglusterfs')
-rw-r--r--libglusterfs/src/common-utils.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/libglusterfs/src/common-utils.c b/libglusterfs/src/common-utils.c
index 6c28690c8ff..66a78e9f7cb 100644
--- a/libglusterfs/src/common-utils.c
+++ b/libglusterfs/src/common-utils.c
@@ -4001,9 +4001,6 @@ gf_is_service_running (char *pidfile, int *pid)
ret = lockf (fno, F_TEST, 0);
if (ret == -1)
running = _gf_true;
- if (!pid) {
- goto out;
- }
ret = fscanf (file, "%d", pid);
if (ret <= 0) {