diff options
| author | Poornima G <pgurusid@redhat.com> | 2017-02-15 11:18:31 +0530 |
|---|---|---|
| committer | Shyamsundar Ranganathan <srangana@redhat.com> | 2017-02-20 07:25:29 -0500 |
| commit | d10c5375b33520f36fd6acbd47b617d43f529ca2 (patch) | |
| tree | 40d8b2f2385e74431fa03bcd4cf5913b8c40e00d /libglusterfs/src/xlator.h | |
| parent | a0f6d7c775fb0de4beff0e326f2865353207b8db (diff) | |
libglusterfs: Fix a crash due to race between inode_ctx_set and inode_ref
Issue:
Currently inode ref count is guarded by inode_table->lock, and
inode_ctx is guarded by inode->lock. With the new patch [1]
inode_ref was modified to change the inode_ctx to track the ref
count per xlator. Thus inode_ref performed under inode_table->lock
is modifying inode_ctx which has to be modified only under inode->lock
Solution:
When a inode is created, inode_ctx holder is allocated for all the xlators.
Hence in case of inode_ctx_set instead of using the first free index in
inode ctx holder, we can have predecided index for every xlator in the graph.
Credits Pranith K <pkarampu@redhat.com>
[1] http://review.gluster.org/13736
> Reviewed-on: https://review.gluster.org/16622
> Smoke: Gluster Build System <jenkins@build.gluster.org>
> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
> Reviewed-by: Niels de Vos <ndevos@redhat.com>
> CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
> Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Change-Id: I1bfe111c211fcc4fcd761bba01dc87c4c69b5170
BUG: 1423385
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: https://review.gluster.org/16655
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Diffstat (limited to 'libglusterfs/src/xlator.h')
| -rw-r--r-- | libglusterfs/src/xlator.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/libglusterfs/src/xlator.h b/libglusterfs/src/xlator.h index 1e2698bb61f..c2959efbd95 100644 --- a/libglusterfs/src/xlator.h +++ b/libglusterfs/src/xlator.h @@ -953,6 +953,9 @@ struct _xlator { /* Saved volfile ID (used for multiplexing) */ char *volfile_id; + + /* Its used as an index to inode_ctx*/ + uint32_t xl_id; }; typedef struct { |