diff options
| author | Amar Tumballi <amarts@redhat.com> | 2018-11-01 07:25:25 +0530 |
|---|---|---|
| committer | Shyamsundar Ranganathan <srangana@redhat.com> | 2018-11-05 18:50:59 +0000 |
| commit | 74e8328d3f6901d6ba38a313965fe910c8411324 (patch) | |
| tree | 4816063d412cf9e436da301fccf165485bf22e18 /libglusterfs/src/statedump.h | |
| parent | 2effe3b0d3fa51fc627c970353de2e326bcf1ef2 (diff) | |
all: fix the format string exceptions
Currently, there are possibilities in few places, where a user-controlled
(like filename, program parameter etc) string can be passed as 'fmt' for
printf(), which can lead to segfault, if the user's string contains '%s',
'%d' in it.
While fixing it, makes sense to make the explicit check for such issues
across the codebase, by making the format call properly.
Fixes: CVE-2018-14661
Fixes: bz#1644763
Change-Id: Ib547293f2d9eb618594cbff0df3b9c800e88bde4
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Diffstat (limited to 'libglusterfs/src/statedump.h')
| -rw-r--r-- | libglusterfs/src/statedump.h | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/libglusterfs/src/statedump.h b/libglusterfs/src/statedump.h index 6c32c161ad3..af653041493 100644 --- a/libglusterfs/src/statedump.h +++ b/libglusterfs/src/statedump.h @@ -81,10 +81,12 @@ void gf_proc_dump_info(int signum, glusterfs_ctx_t *ctx); int -gf_proc_dump_add_section(char *key, ...); +gf_proc_dump_add_section(char *key, ...) + __attribute__((__format__(__printf__, 1, 2))); int -gf_proc_dump_write(char *key, char *value, ...); +gf_proc_dump_write(char *key, char *value, ...) + __attribute__((__format__(__printf__, 2, 3))); void inode_table_dump(inode_table_t *itable, char *prefix); |