diff options
| author | Michael Goulet <mgoulet@fb.com> | 2017-08-24 11:34:42 -0700 |
|---|---|---|
| committer | Jeff Darcy <jeff@pl.atyp.us> | 2017-09-14 20:22:51 +0000 |
| commit | 4d80fcf5ec2098aa4f5aef07dec80ec9eb5ad602 (patch) | |
| tree | df9608c59cb80c190631dd0a1a978b524cdcd1a6 /libglusterfs/src/stack.c | |
| parent | c071992e8d6fee2e5df4d8de19dc0ce1d84a10b8 (diff) | |
nfs: Correctly reconfigure NFS options
Summary:
A mistake was made in D2519423 where `ret` wasn't being set to `0` at the end of `nfs3_init_subvolume_options` since code was inserted between the final `ret = 0` and the return, causing the function to return phony positive ret values.
This causes the code to interpret the reconfigure function as a failure, meaning that changes can't be persisted.
This only affects the `reconfigure` path and not the `init` path, since the `reconfigure` path fails when `ret != 0` and the init path only fails when `ret == -1`...
Test Plan: See that volume options are actually being set when the `nfs` xlator is alive, instead of simply on init.
Reviewers: jdarcy, kvigor, dph, sshreyas
Reviewed By: sshreyas
Subscribers: #posix_storage
Differential Revision: https://phabricator.intern.facebook.com/D5699888
Change-Id: I89006ce3970f22a4206e58ca5630c21df536031c
Signed-off-by: Jeff Darcy <jdarcy@fb.com>
Reviewed-on: https://review.gluster.org/18293
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
Tested-by: Jeff Darcy <jeff@pl.atyp.us>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Diffstat (limited to 'libglusterfs/src/stack.c')
0 files changed, 0 insertions, 0 deletions