diff options
| author | Kaleb S KEITHLEY <kkeithle@redhat.com> | 2015-11-16 10:54:01 -0500 |
|---|---|---|
| committer | Kaleb KEITHLEY <kkeithle@redhat.com> | 2015-11-16 15:20:17 -0800 |
| commit | 1d0a0d180b34961ce03352283c5cb1f0c1561d88 (patch) | |
| tree | a664a23383503b7bf0a7fd7d318638c64cd308ac /libglusterfs/src/graph.y | |
| parent | caae86e6f8b8150ad8663c3173fcd6df3c2e260a (diff) | |
core: use syscall wrappers instead of direct syscalls - tail
tail, as in dog chasing its tail. These are the unwrapped
syscalls that have crept in (or were missed) in the previous
patches.
various xlators and other components are invoking system calls
directly instead of using the libglusterfs/syscall.[ch] wrappers.
If not using the system call wrappers there should be a comment
in the source explaining why the wrapper isn't used.
Change-Id: If183487de92fc7cbc47d4c5aa3f3e80eae50b84f
BUG: 1267967
Signed-off-by: Kaleb S KEITHLEY <kkeithle@redhat.com>
Reviewed-on: http://review.gluster.org/12589
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Diffstat (limited to 'libglusterfs/src/graph.y')
| -rw-r--r-- | libglusterfs/src/graph.y | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/libglusterfs/src/graph.y b/libglusterfs/src/graph.y index 9fd02823a6c..8ac01a25177 100644 --- a/libglusterfs/src/graph.y +++ b/libglusterfs/src/graph.y @@ -25,6 +25,7 @@ #include "xlator.h" #include "graph-utils.h" #include "logging.h" +#include "syscall.h" #include "libglusterfs-messages.h" static int new_volume (char *name); @@ -565,7 +566,7 @@ glusterfs_graph_construct (FILE *fp) if (-1 == tmp_fd) goto err; - ret = unlink (template); + ret = sys_unlink (template); if (ret < 0) { gf_msg ("parser", GF_LOG_WARNING, 0, LG_MSG_FILE_OP_FAILED, "Unable to delete file: %s", template); @@ -606,7 +607,7 @@ err: gf_msg ("parser", GF_LOG_ERROR, 0, LG_MSG_FILE_OP_FAILED, "cannot create temporary file"); if (-1 != tmp_fd) - close (tmp_fd); + sys_close (tmp_fd); } glusterfs_graph_destroy (graph); |