diff options
| author | Ravishankar N <ravishankar@redhat.com> | 2020-09-01 11:36:42 +0530 |
|---|---|---|
| committer | Xavi Hernandez <xhernandez@redhat.com> | 2020-09-04 13:43:30 +0000 |
| commit | 079f7a7d8a2bd85070c1da4dde2452ca82a1cdbb (patch) | |
| tree | 1fc29dad8fca7510e1eec4a8f39bc1344fac89f5 /libglusterfs/src/glusterfs | |
| parent | cede859c7312ad09bae90f6c0f16a751f830905b (diff) | |
libglusterfs: fix dict leak
Problem:
gf_rev_dns_lookup_cached() allocated struct dnscache->dict if it was null
but the freeing was left to the caller.
Fix:
Moved dict allocation and freeing into corresponding init and fini
routines so that its easier for the caller to avoid such leaks.
Updates: #1000
Change-Id: I90d6a6f85ca2dd4fe0ab461177aaa9ac9c1fbcf9
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Diffstat (limited to 'libglusterfs/src/glusterfs')
| -rw-r--r-- | libglusterfs/src/glusterfs/common-utils.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/libglusterfs/src/glusterfs/common-utils.h b/libglusterfs/src/glusterfs/common-utils.h index c998d515fae..f297fdab5c9 100644 --- a/libglusterfs/src/glusterfs/common-utils.h +++ b/libglusterfs/src/glusterfs/common-utils.h @@ -255,6 +255,8 @@ list_node_del(struct list_node *node); struct dnscache * gf_dnscache_init(time_t ttl); +void +gf_dnscache_deinit(struct dnscache *cache); struct dnscache_entry * gf_dnscache_entry_init(void); void |