diff options
| author | Sakshi <sabansal@redhat.com> | 2015-04-15 13:28:24 +0530 |
|---|---|---|
| committer | Jeff Darcy <jdarcy@redhat.com> | 2016-04-14 05:55:50 -0700 |
| commit | d5409aae63a7ac5e5b3ea6cfa16c6250a028291c (patch) | |
| tree | 9da5485f7ef56dd7adca9d7dddf2cbcdf4827cb9 /libglusterfs/src/dict.c | |
| parent | 1c9c776352c60deeda51be66fda6d44bf06d3796 (diff) | |
libglusterfs: coverity fix
fix missing varargs cleanup
CID 1124856: string overflow
CID 1124656: NULL return
CID 1124374: constant expression
Change-Id: Iead530c599bdfef05a40c68b892215f4e4f02247
BUG: 789278
Signed-off-by: Sakshi Bansal <sabansal@redhat.com>
Reviewed-on: http://review.gluster.org/9630
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Diffstat (limited to 'libglusterfs/src/dict.c')
| -rw-r--r-- | libglusterfs/src/dict.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/libglusterfs/src/dict.c b/libglusterfs/src/dict.c index c314a903b91..25ddff0d8c4 100644 --- a/libglusterfs/src/dict.c +++ b/libglusterfs/src/dict.c @@ -2727,6 +2727,11 @@ dict_unserialize (char *orig_buf, int32_t size, dict_t **fill) goto out; } value = get_new_data (); + + if (!value) { + ret = -1; + goto out; + } value->len = vallen; value->data = memdup (buf, vallen); value->is_static = 0; |