diff options
| author | Yaniv Kaul <ykaul@redhat.com> | 2019-11-05 20:37:38 +0200 |
|---|---|---|
| committer | Amar Tumballi <amarts@gmail.com> | 2019-11-27 07:26:19 +0000 |
| commit | 8424df172339d3b2b65bc022e5c8f150f8826dba (patch) | |
| tree | a37ed704a35fdf9f8517cddedc28558c7635aa9e /libglusterfs/src/dict.c | |
| parent | 023a565875891b8078d143a25fee9d44de365c88 (diff) | |
common-utils.c: add gf_strn2boolean() function
The function takes a string and its length and based on it
returns if it's a boolean. It's identical in functionality
to gf_string2boolean only with far less string comparisons since
it takes into account the length of the string.
dict_get_str_boolean() has been converted to use it.
Other cases of gf_string2boolean() across the code base can be
converted as well, but more importantly, they should be converted
from dict_get_str() and then calling to gf_string2boolean to
simply call dict_get_str_boolean(), which would take care of this
for them.
This is therefore a first step in the conversion.
Change-Id: I9ee93abfc676f6e123a3919d8df8c25e8848b799
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Diffstat (limited to 'libglusterfs/src/dict.c')
| -rw-r--r-- | libglusterfs/src/dict.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libglusterfs/src/dict.c b/libglusterfs/src/dict.c index 5f81c48d70f..d786e557fff 100644 --- a/libglusterfs/src/dict.c +++ b/libglusterfs/src/dict.c @@ -2798,7 +2798,7 @@ dict_get_str_boolean(dict_t *this, char *key, int default_val) VALIDATE_DATA_AND_LOG(data, GF_DATA_TYPE_INT, key, -EINVAL); - ret = gf_string2boolean(data->data, &boo); + ret = gf_strn2boolean(data->data, data->len - 1, &boo); if (ret == -1) goto err; |