diff options
| author | Jeff Darcy <jdarcy@fb.com> | 2017-06-29 06:50:56 -0700 |
|---|---|---|
| committer | Niels de Vos <ndevos@redhat.com> | 2017-06-30 10:31:02 +0000 |
| commit | 0be8e038d9bf90be94f3e3a7d6ea5bee88da9ecb (patch) | |
| tree | 2f23f3b205a9bdd386488cc00a3d4b1f23b4a076 /glusterfsd | |
| parent | 50d72373fadf1174918e754e31bae3806aa4c214 (diff) | |
multiple: fix struct/typedef inconsistencies
The most common pattern, both in our code and elsewhere, is this:
struct _xyz {
...
};
typedef struct _xyz xyz_t;
These exceptions - especially call_frame/call_stack - have been slowing
down code navigation for years. By converging on a single pattern,
navigating from xyz_t in code to the actual definition of struct _xyz
(i.e. without having to visit the typedef first) might even be
automatable.
Change-Id: I0e5dd1f51f98e000173c62ef4ddc5b21d9ec44ed
Signed-off-by: Jeff Darcy <jdarcy@fb.com>
Reviewed-on: https://review.gluster.org/17650
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Jeff Darcy <jeff@pl.atyp.us>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Diffstat (limited to 'glusterfsd')
| -rw-r--r-- | glusterfsd/src/glusterfsd.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/glusterfsd/src/glusterfsd.h b/glusterfsd/src/glusterfsd.h index bc3f2605466..3461d6d01f0 100644 --- a/glusterfsd/src/glusterfsd.h +++ b/glusterfsd/src/glusterfsd.h @@ -98,7 +98,7 @@ enum argp_option_keys { #endif }; -struct _gfd_vol_top_priv_t { +struct _gfd_vol_top_priv { rpcsvc_request_t *req; gd1_mgmt_brick_op_req xlator_req; uint32_t blk_count; @@ -107,7 +107,7 @@ struct _gfd_vol_top_priv_t { double time; int32_t ret; }; -typedef struct _gfd_vol_top_priv_t gfd_vol_top_priv_t; +typedef struct _gfd_vol_top_priv gfd_vol_top_priv_t; int glusterfs_mgmt_pmap_signout (glusterfs_ctx_t *ctx, char *brick_name); int glusterfs_mgmt_pmap_signin (glusterfs_ctx_t *ctx); |