diff options
| author | Aravinda VK <avishwan@redhat.com> | 2016-09-09 12:40:38 +0530 |
|---|---|---|
| committer | Aravinda VK <avishwan@redhat.com> | 2016-09-15 02:29:04 -0700 |
| commit | 8668906b112a4053feecfea2072f7eb0a73a043c (patch) | |
| tree | 8649796883537d91dd4b015f5371a2953d0a502e /events | |
| parent | bb80a6be93236e5a7cb86abfd80fb57509599089 (diff) | |
eventsapi: Add conditional import for requests library
requests lib is used only during publishing event. gf_event python
imports utils.py, and indirectly imports requests lib even though
it is not required while sending event to eventsd.
Moved "import requests" inside the "plugin_webhook" function.
> Reviewed-on: http://review.gluster.org/15439
> Reviewed-by: Prashanth Pai <ppai@redhat.com>
> Smoke: Gluster Build System <jenkins@build.gluster.org>
> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
> Reviewed-by: Kotresh HR <khiremat@redhat.com>
> CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
BUG: 1375537
Change-Id: Ie3c8088b43d4d7952d01352731999bf8519c73c4
Signed-off-by: Aravinda VK <avishwan@redhat.com>
(cherry picked from commit aa742fd88e08eeb807dba1cb98402e8813ec6797)
Reviewed-on: http://review.gluster.org/15487
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Diffstat (limited to 'events')
| -rw-r--r-- | events/src/utils.py | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/events/src/utils.py b/events/src/utils.py index db8ebfe29a9..dadd9ae3332 100644 --- a/events/src/utils.py +++ b/events/src/utils.py @@ -15,7 +15,6 @@ import logging import fcntl from errno import ESRCH, EBADF -import requests from eventsapiconf import (LOG_FILE, WEBHOOKS_FILE, DEFAULT_CONFIG_FILE, @@ -145,6 +144,9 @@ def publish(ts, event_key, data): def plugin_webhook(message): + # Import requests here since not used in any other place + import requests + message_json = json.dumps(message, sort_keys=True) logger.debug("EVENT: {0}".format(message_json)) for url, token in _webhooks.items(): |