summaryrefslogtreecommitdiffstats
path: root/cli
diff options
context:
space:
mode:
authorMohammed Azhar Padariyakam <mpadariy@redhat.com>2017-09-21 20:19:44 +0530
committerNiels de Vos <ndevos@redhat.com>2017-09-29 09:28:39 +0000
commite348b4df9bfd80be5c521bc4c76faf2693e90692 (patch)
tree42d43d53292e1acc8f3be21b9de4a34cb76e5b01 /cli
parentd01a674077f2411ecde7bd6037efbfcf6faa65ba (diff)
cli: fix Coverity warning DEADCODE in gf_cli_attach_tier()
Issue : At condition "ret", the value of "ret" must be equal to 0. The condition "ret" cannot be true since the value is always 0. Hence, the execution cannot reach the statement "goto out" Solution : The never-true if-condition and its body has to be removed Fix : The always false if-condition and the dead code under this if-condition was removed. Change-Id: I5c038b8ec9abf9b2f06dcfd981904b9dca1a0094 BUG: 789278 Signed-off-by: Mohammed Azhar Padariyakam <mpadariy@redhat.com>
Diffstat (limited to 'cli')
-rw-r--r--cli/src/cli-rpc-ops.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/cli/src/cli-rpc-ops.c b/cli/src/cli-rpc-ops.c
index fcb451a..1a92fb5 100644
--- a/cli/src/cli-rpc-ops.c
+++ b/cli/src/cli-rpc-ops.c
@@ -4992,9 +4992,6 @@ gf_cli_attach_tier (call_frame_t *frame, xlator_t *this,
dict = data;
- if (ret)
- goto out;
-
ret = cli_to_glusterd (&req, frame, gf_cli_attach_tier_cbk,
(xdrproc_t) xdr_gf_cli_req, dict,
GLUSTER_CLI_ATTACH_TIER, this,