summaryrefslogtreecommitdiffstats
path: root/cli/src
diff options
context:
space:
mode:
authorRichard Wareing <rwareing@fb.com>2014-12-03 20:44:46 -0800
committerKevin Vigor <kvigor@fb.com>2017-03-05 15:48:04 -0500
commit6551daaf88fc290eeb25077233c79d39aaa51f05 (patch)
treee56af559967a2ed256d243e719f9d94be653abad /cli/src
parent4f9624bf078064cfcd49da714437e0ed94bbffbe (diff)
Increase CLI command timeout to 600 seconds for all commands
Summary: - Increase CLI command timeout to 600 seconds from 120 for use with large cluster creations - My first attempt at this patch made an exception for create's only, but this proved to be a bad idea as then other commands would fail (such as start for example); so let's increase them all globally. - The reason this timeout comes into play for large vol creates, is that the create flow is rather serial in nature and takes proportionately longer as the number of bricks increases. - Parallelizing the CLI commands better may be some worthy future work Test Plan: - Run gluster vol create command w/ 264 bricks, prior to this patch it timed @ 120 seconds, afterwards it completes successfully - Run gluster vol start command w/264 bricks, observe that it completes successfully Example output: https://phabricator.fb.com/P18037176 Reviewers: jackl, dph Reviewed By: dph Conflicts: cli/src/cli.h FB-commit-id: e1f729e Change-Id: I22c420fe17ad57b772e0061ad707cc2eeed1e01d Signed-off-by: Kevin Vigor <kvigor@fb.com> Reviewed-on: https://review.gluster.org/16848 CentOS-regression: Gluster Build System <jenkins@build.gluster.org> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org> Reviewed-by: Shreyas Siravara <sshreyas@fb.com> Smoke: Gluster Build System <jenkins@build.gluster.org>
Diffstat (limited to 'cli/src')
-rw-r--r--cli/src/cli.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/cli/src/cli.c b/cli/src/cli.c
index fa507309e80..58fd9104f81 100644
--- a/cli/src/cli.c
+++ b/cli/src/cli.c
@@ -712,7 +712,7 @@ main (int argc, char *argv[])
if (ret)
goto out;
- cli_default_conn_timeout = 120;
+ cli_default_conn_timeout = 600;
cli_ten_minutes_timeout = 600;
ret = cli_state_init (&state);