summaryrefslogtreecommitdiffstats
path: root/api
diff options
context:
space:
mode:
authorKinglong Mee <mijinlong@open-fs.com>2019-01-03 17:07:27 +0800
committerNiels de Vos <ndevos@redhat.com>2019-01-07 09:20:21 +0000
commitf99f51ca87fd8703947df985901cbce37bc6c818 (patch)
treed73157d36b80776bdcd4807d3ee7c4b308baf83a /api
parenta9b0003c717087ff168bc143c70559162e53e0d5 (diff)
glfs-fops.c: fix the bad string length for snprintf
Snprintf reserves one byte for the ending '\0'. A NAME_MAX bytes d_name is truncated to NAME_MAX - 1 bytes. Change-Id: Ic884d18cee24360e55ddb896dc587b0b74ef97fe updates: bz#1193929 Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
Diffstat (limited to 'api')
-rw-r--r--api/src/glfs-fops.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/api/src/glfs-fops.c b/api/src/glfs-fops.c
index 03a15e6..272e75c 100644
--- a/api/src/glfs-fops.c
+++ b/api/src/glfs-fops.c
@@ -3413,7 +3413,7 @@ gf_dirent_to_dirent(gf_dirent_t *gf_dirent, struct dirent *dirent)
dirent->d_namlen = strlen(gf_dirent->d_name);
#endif
- snprintf(dirent->d_name, NAME_MAX, "%s", gf_dirent->d_name);
+ snprintf(dirent->d_name, NAME_MAX + 1, "%s", gf_dirent->d_name);
}
int
@@ -4904,7 +4904,7 @@ retry:
goto out;
if (loc.path) {
- snprintf(retpath, PATH_MAX, "%s", loc.path);
+ snprintf(retpath, PATH_MAX + 1, "%s", loc.path);
}
out: