diff options
| author | Soumya Koduri <skoduri@redhat.com> | 2017-05-03 18:39:14 +0530 |
|---|---|---|
| committer | Shyamsundar Ranganathan <srangana@redhat.com> | 2017-05-07 15:34:01 +0000 |
| commit | d60d7c8939de76f99562a042bf8d42c5e64e63d1 (patch) | |
| tree | 2317a3e669193b1e60fd679fe60f4d71e8d2eecb /api/src/glfs-mgmt.c | |
| parent | 714e5505b036f708a4594473d475dbe2c94494ec (diff) | |
gfapi: Fix few severe coverity issues
From https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-05-03-6484558c/html/
fixes coverity#189, 248, 250, 488, 546
This is backport of below mainline fix -
- https://review.gluster.org/17161
>Change-Id: I7c4aa5bf6c367344602748dfd736de27f341cca2
>BUG: 789278
>Signed-off-by: Soumya Koduri <skoduri@redhat.com>
>Reviewed-on: https://review.gluster.org/17161
>Smoke: Gluster Build System <jenkins@build.gluster.org>
>Reviewed-by: Niels de Vos <ndevos@redhat.com>
>NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
>Reviewed-by: Amar Tumballi <amarts@redhat.com>
>CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
>(cherry picked from commit fa10c8a3528b95dc575bfedd30bcd68cc2dff25b)
Change-Id: I7c4aa5bf6c367344602748dfd736de27f341cca2
BUG: 1447571
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Reviewed-on: https://review.gluster.org/17194
Reviewed-by: Niels de Vos <ndevos@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Diffstat (limited to 'api/src/glfs-mgmt.c')
| -rw-r--r-- | api/src/glfs-mgmt.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/api/src/glfs-mgmt.c b/api/src/glfs-mgmt.c index 1726dac6ce4..bb4e77a1467 100644 --- a/api/src/glfs-mgmt.c +++ b/api/src/glfs-mgmt.c @@ -984,7 +984,8 @@ glfs_mgmt_init (struct glfs *fs) host = "localhost"; } - if (!strcmp (cmd_args->volfile_server_transport, "unix")) { + if (cmd_args->volfile_server_transport && + !strcmp (cmd_args->volfile_server_transport, "unix")) { ret = rpc_transport_unix_options_build (&options, host, 0); } else { ret = rpc_transport_inet_options_build (&options, host, port); |