diff options
| author | Xavi Hernandez <xhernandez@redhat.com> | 2019-06-25 18:00:06 +0200 |
|---|---|---|
| committer | Atin Mukherjee <amukherj@redhat.com> | 2019-06-26 03:08:34 +0000 |
| commit | f36086db87aae24c10abde434f081d78b942735e (patch) | |
| tree | 6f305a9da5e172700671e5d7bca58e75114c5532 | |
| parent | 40c18b189f31a87b5c5f9344c4a0ab44cb61ef75 (diff) | |
glusterd: fix use-after-free of a dict_t
A dict was passed to a function that calls dict_unref() without taking
any additional reference. Given that the same dict is also used after
the function returns, this was causing a use-after-free situation.
To fix the issue, we simply take an additional reference before calling
the function.
Fixes: bz#1723890
Change-Id: I98c6b76b08fe3fa6224edf281a26e9ba1ffe3017
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
| -rw-r--r-- | xlators/mgmt/glusterd/src/glusterd-utils.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-utils.c b/xlators/mgmt/glusterd/src/glusterd-utils.c index b004b2e42d6..80fb82938e5 100644 --- a/xlators/mgmt/glusterd/src/glusterd-utils.c +++ b/xlators/mgmt/glusterd/src/glusterd-utils.c @@ -3452,7 +3452,7 @@ glusterd_add_volumes_to_export_dict(dict_t *peer_data, char **buf, if (totthread) { gf_log(this->name, GF_LOG_INFO, "Finished merger of all dictionraies into single one"); - dict_arr[totthread++] = peer_data; + dict_arr[totthread++] = dict_ref(peer_data); ret = glusterd_dict_arr_serialize(dict_arr, totthread, buf, length); gf_log(this->name, GF_LOG_INFO, "Serialize dictionary data return is %d", ret); |