summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAtin Mukherjee <amukherj@redhat.com>2015-08-05 16:02:49 +0530
committerPranith Kumar Karampuri <pkarampu@redhat.com>2016-02-01 03:03:12 -0800
commitccdfa49c90d0adfd32f9f6d3443e8762e9cd6b0e (patch)
tree22b0738e1532844ac0d9952ebcc254f28c7f066a
parent204115c58622b5a15e1de8b6a909d77fdb49a226 (diff)
glusterd: improve error logs for unsupported clientsv3.7.7
Backport of http://review.gluster.org/11831 Change-Id: I90be46a7b25cc3efd0e61c9a145852e9027f5f64 BUG: 1302521 Signed-off-by: Atin Mukherjee <amukherj@redhat.com> Reviewed-on: http://review.gluster.org/11831 Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com> Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com> Smoke: Gluster Build System <jenkins@build.gluster.com> CentOS-regression: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Prashanth Pai <ppai@redhat.com> Reviewed-by: Kaushal M <kaushal@redhat.com> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org> Reviewed-on: http://review.gluster.org/13305
-rw-r--r--xlators/mgmt/glusterd/src/glusterd-utils.c22
1 files changed, 15 insertions, 7 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-utils.c b/xlators/mgmt/glusterd/src/glusterd-utils.c
index 281aff8..5ccfcf4 100644
--- a/xlators/mgmt/glusterd/src/glusterd-utils.c
+++ b/xlators/mgmt/glusterd/src/glusterd-utils.c
@@ -10766,14 +10766,22 @@ glusterd_check_client_op_version_support (char *volname, uint32_t op_version,
if (ret) {
gf_msg (this->name, GF_LOG_ERROR, 0,
GD_MSG_UNSUPPORTED_VERSION,
- "One or more clients "
- "don't support the required op-version");
+ "Client %s is running with min_op_version as %d and "
+ "max_op_version as %d and don't support the required "
+ "op-version %d", xprt->peerinfo.identifier,
+ xprt->peerinfo.min_op_version,
+ xprt->peerinfo.max_op_version, op_version);
if (op_errstr)
- ret = gf_asprintf (op_errstr, "One or more connected "
- "clients cannot support the feature "
- "being set. These clients need to be"
- " upgraded or disconnected before "
- "running this command again");
+ ret = gf_asprintf (op_errstr, "One of the client %s is "
+ "running with op-version %d and "
+ "doesn't support the required "
+ "op-version %d. This client needs to"
+ " be upgraded or disconnected "
+ "before running this command again",
+ xprt->peerinfo.identifier,
+ xprt->peerinfo.max_op_version,
+ op_version);
+
return -1;
}
return 0;