summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSunny Kumar <sunkumar@redhat.com>2018-09-11 16:53:29 +0530
committerAtin Mukherjee <amukherj@redhat.com>2018-09-17 12:08:19 +0000
commitbdfe87d56b21766cf7fe9f73890d1d3336158982 (patch)
treeb3de0a04857c998ceb1c26a2369305ead90dedda
parentfb836edec5f0bd805c302497d78fa85937d9d4dc (diff)
glusterd : fix coverity issue in glusterd-store.c
This patch fixes CID 1124356: Unchecked return value (CHECKED_RETURN) updates: bz#789278 Change-Id: I81f4637f19b81f820a2deb70cc7f84b79fe70236 Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
-rw-r--r--xlators/mgmt/glusterd/src/glusterd-store.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-store.c b/xlators/mgmt/glusterd/src/glusterd-store.c
index b5de958f8be..e04a3d493d9 100644
--- a/xlators/mgmt/glusterd/src/glusterd-store.c
+++ b/xlators/mgmt/glusterd/src/glusterd-store.c
@@ -3354,7 +3354,12 @@ _store_global_opts(dict_t *this, char *key, data_t *value, void *data)
{
gf_store_handle_t *shandle = data;
- gf_store_save_value(shandle->fd, key, (char *)value->data);
+ if (gf_store_save_value(shandle->fd, key, (char *)value->data)) {
+ gf_msg(THIS->name, GF_LOG_ERROR, 0, GD_MSG_STORE_HANDLE_WRITE_FAIL,
+ "Unable to write into store handle for key : %s, value %s", key,
+ (char *)value->data);
+ }
+
return 0;
}