diff options
authorSanju Rakonde <>2018-07-04 14:45:51 +0530
committerAtin Mukherjee <>2018-07-06 06:10:10 +0000
commit99a1e816ceae107694fa14d755cec91e159f0a2d (patch)
parent06cdc956096440eebf9984312af7db6f842578fc (diff)
glusterd: Fix glusterd crash
Problem: gluster get-state command is crashing glusterd process, when geo-replication session is configured. Cause: Crash is happening due to the double free of memory. In glusterd_print_gsync_status_by_vol we are calling dict_unref(), which will free all the keys and values in the dictionary. Before calling dict_unref(), glusterd_print_gsync_status_by_vol is calling glusterd_print_gsync_status(). glusterd_print_gsync_status is freeing up values in the dictionary and again when dict_unref() is called, it tries to free up the values which are already freed. Solution: Remove the code which will free the memory in glusterd_print_gsync_status function. Fixes: bz#1598345 Change-Id: Id3d8aae109f377b462bbbdb96a8e3c5f6b0be752 Signed-off-by: Sanju Rakonde <>
1 files changed, 0 insertions, 9 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-handler.c b/xlators/mgmt/glusterd/src/glusterd-handler.c
index 6d513bb90b1..dd81887ed1f 100644
--- a/xlators/mgmt/glusterd/src/glusterd-handler.c
+++ b/xlators/mgmt/glusterd/src/glusterd-handler.c
@@ -5096,15 +5096,6 @@ glusterd_print_gsync_status (FILE *fp, dict_t *gsync_dict)
volcount, i+1, get_struct_variable(15, status_vals[i]));
- for (i = 0; i < gsync_count; i++) {
- if (status_vals[i]) {
- GF_FREE (status_vals[i]);
- }
- }
- if (status_vals)
- GF_FREE (status_vals);
return ret;