summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKartik_Burmee <kburmee@redhat.com>2017-11-13 16:48:26 +0530
committerAtin Mukherjee <amukherj@redhat.com>2017-11-14 04:53:03 +0000
commit87d5fb2ca50ab2812eabc7373216c45a5b4d16df (patch)
tree30c30c1671a04e29583d851b7444375395668139
parent27e5fbf6eeeb2402a625a20c966324dea3d6a876 (diff)
glusterd: dead code coverity fix
function: glusterd_volume_rebalance_use_rsp_dict problem: Execution cannot reach this statement: "goto out;" fix: removed the condition 'if(!ctx_dict)' and the corresponding action 'goto out;' because it will never be executed. reason: if the execution reaches this condition, then the value of '!ctx_dict' will always be false otherwise the execution will reach the 'out' label, skipping the execution of this conditional statement. html link of issue: https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-11-10-0f524f07/html/1/99glusterd-utils.c.html#error Change-Id: I7ab6b2386bb01c54edd872f9f83bb8d2a4cd499f BUG: 789278 Signed-off-by: Kartik_Burmee <kburmee@redhat.com>
-rw-r--r--xlators/mgmt/glusterd/src/glusterd-utils.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-utils.c b/xlators/mgmt/glusterd/src/glusterd-utils.c
index ede2a9260a5..a50a294176b 100644
--- a/xlators/mgmt/glusterd/src/glusterd-utils.c
+++ b/xlators/mgmt/glusterd/src/glusterd-utils.c
@@ -10498,8 +10498,6 @@ glusterd_volume_rebalance_use_rsp_dict (dict_t *aggr, dict_t *rsp_dict)
goto out;
}
- if (!ctx_dict)
- goto out;
ret = dict_get_str (ctx_dict, "volname", &volname);
if (ret) {