diff options
| author | ShyamsundarR <srangana@redhat.com> | 2018-08-13 15:11:15 -0400 |
|---|---|---|
| committer | Amar Tumballi <amarts@redhat.com> | 2018-08-16 06:09:23 +0000 |
| commit | 82e5acd6b30aabccb0a1e157dc633591c4919a3e (patch) | |
| tree | 72280f77376725245d28256719330b973805f1f2 | |
| parent | e765dfa0704bed07eaf003c007d9ab192cdd8aa4 (diff) | |
tests: Fix spurious failures in stats-dump.t test
The test fails to grep and find queue_size, in a brick stats
dump, having succesfully found aggr.* values in the same.
The troubleshot is that, the writer thread in io-stats, that
dumps this in a particular interval, truncates the file just before
the grep attempts to read the contents, and hence the failure.
The fix is to stop the dumper thread, and then wait for a couple
of seconds and then check the output, so that the thread writer
does not interfere with the test.
Fixes: bz#1615582
Change-Id: I29f95488a2ad693abe1dd525b1d87a9d1eee29a2
Signed-off-by: ShyamsundarR <srangana@redhat.com>
| -rw-r--r-- | tests/basic/stats-dump.t | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/tests/basic/stats-dump.t b/tests/basic/stats-dump.t index 3eed80e5579..054df2e636f 100644 --- a/tests/basic/stats-dump.t +++ b/tests/basic/stats-dump.t @@ -26,8 +26,16 @@ done for i in {1..10};do dd if=/dev/zero of=$N0/nfs_testfile$i bs=4k count=100 done + +# Wait for one dump interval to be done, some seconds past 1 that is the dump +# interval set sleep 2 +# Change the dump interval to 0, so that when reading the file contents we +# do not get them truncated by the next interval that is overwriting the latest +# stats data +TEST $CLI volume set $V0 diagnostics.stats-dump-interval 0 + # Verify we have non-zero write counts from the bricks, gNFSd # and the FUSE mount. TEST [ $(grep 'aggr.fop.write.count' ${GLUSTERD_WORKDIR}/stats/glusterfs_nfsd.dump|tail -1|cut -d: -f2) != "0," ] |