summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMohit Agrawal <moagrawa@redhat.com>2016-10-26 16:31:58 +0530
committerJeff Darcy <jdarcy@redhat.com>2016-11-10 06:45:19 -0800
commit7874ed245bcc80658547992205f8396f4dd3c76a (patch)
tree5e5fa34df194f59c4f0c46287af0e8325212363e
parent28393888c59873efe912c4634f20f6bce3373588 (diff)
glusterfsd: Continuous errors are getting in mount logs while glusterd is down
Problem: when glusterd is down, getting the continuous mgmt_rpc_notify errors messages in the volume mount log for every 3 seconds,it will consume disk space. Solution: To reduce the frequency of error messages use GF_LOG_OCCASIONALLY. BUG: 1388877 Change-Id: I6cf24c6ddd9ab380afd058bc0ecd556d664332b1 Signed-off-by: Mohit Agrawal <moagrawa@redhat.com> Reviewed-on: http://review.gluster.org/15732 NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org> Smoke: Gluster Build System <jenkins@build.gluster.org> CentOS-regression: Gluster Build System <jenkins@build.gluster.org> Reviewed-by: Raghavendra Talur <rtalur@redhat.com> Reviewed-by: Raghavendra G <rgowdapp@redhat.com> Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
-rw-r--r--glusterfsd/src/glusterfsd-mgmt.c9
1 files changed, 6 insertions, 3 deletions
diff --git a/glusterfsd/src/glusterfsd-mgmt.c b/glusterfsd/src/glusterfsd-mgmt.c
index 00da4b0df19..47093609f2c 100644
--- a/glusterfsd/src/glusterfsd-mgmt.c
+++ b/glusterfsd/src/glusterfsd-mgmt.c
@@ -1912,6 +1912,8 @@ mgmt_rpc_notify (struct rpc_clnt *rpc, void *mydata, rpc_clnt_event_t event,
rpc_transport_t *rpc_trans = NULL;
int need_term = 0;
int emval = 0;
+ static int log_ctr1;
+ static int log_ctr2;
struct dnscache6 *dnscache = NULL;
this = mydata;
@@ -1920,7 +1922,7 @@ mgmt_rpc_notify (struct rpc_clnt *rpc, void *mydata, rpc_clnt_event_t event,
switch (event) {
case RPC_CLNT_DISCONNECT:
- gf_log ("glusterfsd-mgmt", GF_LOG_ERROR,
+ GF_LOG_OCCASIONALLY (log_ctr1, "glusterfsd-mgmt", GF_LOG_ERROR,
"failed to connect with remote-host: %s (%s)",
ctx->cmd_args.volfile_server, strerror (errno));
if (!rpc->disabled) {
@@ -1938,8 +1940,9 @@ mgmt_rpc_notify (struct rpc_clnt *rpc, void *mydata, rpc_clnt_event_t event,
if (!ctx->active)
need_term = 1;
emval = ENOTCONN;
- gf_log("glusterfsd-mgmt", GF_LOG_INFO,
- "Exhausted all volfile servers");
+ GF_LOG_OCCASIONALLY (log_ctr2, "glusterfsd-mgmt",
+ GF_LOG_INFO,
+ "Exhausted all volfile servers");
break;
}
server = list_entry (server->list.next, typeof(*server), list);