summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorsrijan-sivakumar <ssivakum@redhat.com>2020-09-21 19:31:08 +0530
committerSanju Rakonde <sanjurakonde@review.gluster.org>2020-09-24 03:31:03 +0000
commit5a1644c892adeb370fdd6eb2adf0d49e0cf553b4 (patch)
treeb7b593318eed58a7cd4932db5b600434a20efde7
parent168142748d4f676071d9253bb536aec734a4a0da (diff)
glusterd: Fixing coverity issues.
Fixing Incorrect expression (IDENTICAL_BRANCHES) reported by the coverity scan. CID: 1432721 Change-Id: If6ab3a129dffb6c5fcc618e775f99bc1125003ab Updates: #1060 Signed-off-by: srijan-sivakumar <ssivakum@redhat.com>
-rw-r--r--xlators/mgmt/glusterd/src/glusterd-store.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-store.c b/xlators/mgmt/glusterd/src/glusterd-store.c
index e714fae..af6a6be 100644
--- a/xlators/mgmt/glusterd/src/glusterd-store.c
+++ b/xlators/mgmt/glusterd/src/glusterd-store.c
@@ -3415,14 +3415,12 @@ glusterd_store_options(xlator_t *this, dict_t *opts)
}
ret = gf_store_rename_tmppath(shandle);
- if (ret) {
- goto out;
- }
out:
shandle->fd = 0;
GF_FREE(dict_data);
- if ((ret < 0) && (fd > 0))
+ if ((ret < 0) && (fd > 0)) {
gf_store_unlink_tmppath(shandle);
+ }
gf_store_handle_destroy(shandle);
return ret;
}