summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSunny Kumar <sunkumar@redhat.com>2020-01-10 14:28:35 +0000
committerAravinda Vishwanathapura <mail@aravindavk.in>2020-01-13 03:19:35 +0000
commit33c3cbe71b67f523538b04334f1ef962953281ed (patch)
tree26d33ecae2914c650e99ada2498a2a23f5cb3bd4
parent45894c39a4d05ed1f6a6f1bdbeafb5fe74ef29c3 (diff)
glusterfind: python3 compatibility
Problem: While we delete gluster volume the hook script 'S57glusterfind-delete-post.py' is failed to execute and error message can be observed in glusterd log. Traceback: File "/var/lib/glusterd/hooks/1/delete/post/S57glusterfind-delete-post", line 69, in <module> main() File "/var/lib/glusterd/hooks/1/delete/post/S57glusterfind-delete-post", line 39, in main glusterfind_dir = os.path.join(get_glusterd_workdir(), "glusterfind") File "/usr/lib64/python3.7/posixpath.py", line 94, in join genericpath._check_arg_types('join', a, *p) File "/usr/lib64/python3.7/genericpath.py", line 155, in _check_arg_types raise TypeError("Can't mix strings and bytes in path components") from None TypeError: Can't mix strings and bytes in path components Solution: Added the 'universal_newlines' flag to Popen to support backward compatibility. Change-Id: Ie5655b11b55535c5ad2338108d0448e6fdaacf4f Fixes: bz#1789478 Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
-rwxr-xr-xtools/glusterfind/S57glusterfind-delete-post.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/glusterfind/S57glusterfind-delete-post.py b/tools/glusterfind/S57glusterfind-delete-post.py
index 5b5142d..5beece2 100755
--- a/tools/glusterfind/S57glusterfind-delete-post.py
+++ b/tools/glusterfind/S57glusterfind-delete-post.py
@@ -18,7 +18,7 @@ def handle_rm_error(func, path, exc_info):
def get_glusterd_workdir():
p = Popen(["gluster", "system::", "getwd"],
- stdout=PIPE, stderr=PIPE)
+ stdout=PIPE, stderr=PIPE, universal_newlines=True)
out, _ = p.communicate()