summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAmar Tumballi <amar@gluster.com>2009-08-04 17:51:58 +0000
committerAnand V. Avati <avati@dev.gluster.com>2009-08-04 17:07:08 -0700
commit33b5ce10ef7b5c6db6e73f6070fd4579c2765c94 (patch)
tree9db37ee9180d0eaef0ba09122cc7f266d83b9b22
parentedd633f30adba95c65d29c58a2562ccbb18c3495 (diff)
logging related bug fix in server_lookup()
When 'dict_unserialize' failed, the log message was trying to print 'state->loc.path' and 'state->ino', which gets filled in later stages in flow. Caused segmentation fault when there was a failure. Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 189 (segfault in server-lookup) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=189
-rw-r--r--xlators/protocol/server/src/server-protocol.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/xlators/protocol/server/src/server-protocol.c b/xlators/protocol/server/src/server-protocol.c
index 00964698b7e..2516756b2c4 100644
--- a/xlators/protocol/server/src/server-protocol.c
+++ b/xlators/protocol/server/src/server-protocol.c
@@ -3442,10 +3442,9 @@ server_lookup (call_frame_t *frame, xlator_t *bound_xl,
&xattr_req);
if (ret < 0) {
gf_log (bound_xl->name, GF_LOG_ERROR,
- "%"PRId64": %s (%"PRId64"): failed to "
- "unserialize request buffer to dictionary",
- frame->root->unique, state->loc.path,
- state->ino);
+ "%"PRId64": failed to unserialize "
+ "request buffer to dictionary",
+ frame->root->unique);
free (req_dictbuf);
goto fail;
} else{